[bug report] drm/amdgpu: add amdgpu_ras.c to support ras (v2)

Dan Carpenter dan.carpenter at oracle.com
Wed May 6 11:33:03 UTC 2020

On Wed, May 06, 2020 at 10:10:56AM +0000, Pan, Xinhui wrote:
> [AMD Official Use Only - Internal Distribution Only]
> no.  below function checks if block is valid or not.
> I think you need check your code_checker. or you were checking on a very old codebase?
> /* check if ras is supported on block, say, sdma, gfx */
> static inline int amdgpu_ras_is_supported(struct amdgpu_device *adev,
> unsigned int block)

Ah!  That's right.  Thanks.

What happens here is that Smatch thinks amdgpu_ras_is_supported() always
returns false because there is a bug in how it tracks ras->supported.
I will fix this.

dan carpenter

More information about the amd-gfx mailing list