[PATCH] drm/amd/powerplay: skip judging if baco support for Arcturus sriov

Jian, Jane Jane.Jian at amd.com
Mon May 11 06:26:02 UTC 2020

[AMD Official Use Only - Internal Distribution Only]

Hi @Quan, Evan,
Could you please help to review this patch?
Since this is previously your patch here.

-----Original Message-----
From: Jane Jian <Jane.Jian at amd.com> 
Sent: Saturday, May 9, 2020 4:07 PM
To: amd-gfx at lists.freedesktop.org; Quan, Evan <Evan.Quan at amd.com>
Cc: Jian, Jane <Jane.Jian at amd.com>; Min, Frank <Frank.Min at amd.com>
Subject: [PATCH] drm/amd/powerplay: skip judging if baco support for Arcturus sriov

since for sriov, baco happens on host side, no need and meaning to judge is baco.
also, since kiq reads strap0 in here, if kiq is not ready or gpu reset(kiq resume) happens after this read, would fail to read and wrongly set baco as true(1).

Change-Id: Ib67f837edfbf09263133d5614f6dbb890cf27b12
Signed-off-by: Jane Jian <Jane.Jian at amd.com>
 drivers/gpu/drm/amd/powerplay/arcturus_ppt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
index 1c66b7d7139c..cfae4bcaf32e 100644
--- a/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
+++ b/drivers/gpu/drm/amd/powerplay/arcturus_ppt.c
@@ -2251,7 +2251,7 @@ static bool arcturus_is_baco_supported(struct smu_context *smu)
 	struct amdgpu_device *adev = smu->adev;
 	uint32_t val;
-	if (!smu_v11_0_baco_is_support(smu))
+	if (!smu_v11_0_baco_is_support(smu) || amdgpu_sriov_vf(adev))
 		return false;
 	val = RREG32_SOC15(NBIO, 0, mmRCC_BIF_STRAP0);

More information about the amd-gfx mailing list