[PATCH 1/3] Revert "drm/amdgpu: off by one in amdgpu_device_attr_create_groups() error handling"

[Alex Deucher]

On Fri, May 22, 2020 at 6:25 AM Christian König
<ckoenig.leichtzumerken at gmail.com> wrote:
>
> Well what exactly is going wrong here?
>
> At least this one looks correct to me, and if it blocks the revert we
> should probably squash it in there as well.

I can squash them together.  These were just dependences.  The issue
is the third patch.

Alex


>
> Christian.
>
> Am 21.05.20 um 22:23 schrieb Alex Deucher:
> > This reverts commit b41d9df2b680b96913cc3ccf929252e2dce71b24.
> >
> > Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> > ---
> >   drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> > index 2fc51f815eaa..72bbb8175b22 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_pm.c
> > @@ -1843,8 +1843,9 @@ static int amdgpu_device_attr_create_groups(struct amdgpu_device *adev,
> >       return 0;
> >
> >   failed:
> > -     while (i--)
> > +     for (; i > 0; i--) {
> >               amdgpu_device_attr_remove(adev, &attrs[i]);
> > +     }
> >
> >       return ret;
> >   }
>