[PATCH] drm/amdgpu/smu10: Replace one-element array and use struct_size() helper

Gustavo A. R. Silva gustavoars at kernel.org
Fri May 22 17:51:42 UTC 2020


On Wed, May 20, 2020 at 09:42:27AM +0200, Christian König wrote:
> > 
> > Signed-off-by: Gustavo A. R. Silva <gustavoars at kernel.org>
> 
> Acked-by: Christian König <christian.koenig at amd.com>
> 
> May I suggest that we add a section how to correctly do this to
> Documentation/process/coding-style.rst or similar document?
> 

That's already on my list. :)

> I've seen a bunch of different approaches and some even doesn't work with
> some gcc versions and result in a broken binary.
> 

Do you have an example of that one that doesn't work with some GCC
versions? It'd be interesting to take a look...

Thanks
--
Gustavo


More information about the amd-gfx mailing list