[PATCH] amdkfd: Check kvmalloc return before memcpy

[Felix Kuehling]

Am 2020-11-02 um 11:27 a.m. schrieb Kent Russell:
> If we can't kvmalloc the pcrat_image, then we shouldn't memcpy
>
> Signed-off-by: Kent Russell <kent.russell at amd.com>
> Reported-by: kernel test robot <lkp at intel.com>

Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com>


> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> index cdd5032d5c0e..a0acf2310357 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> @@ -804,10 +804,10 @@ int kfd_create_crat_image_acpi(void **crat_image, size_t *size)
>  	}
>  
>  	pcrat_image = kvmalloc(crat_table->length, GFP_KERNEL);
> -	memcpy(pcrat_image, crat_table, crat_table->length);
>  	if (!pcrat_image)
>  		return -ENOMEM;
>  
> +	memcpy(pcrat_image, crat_table, crat_table->length);
>  	*crat_image = pcrat_image;
>  	*size = crat_table->length;
>