[PATCH] drm/amdgpu: fix off by one in amdgpu_vm_handle_fault

[Alex Deucher]

On Mon, Nov 2, 2020 at 11:23 AM Christian König
<ckoenig.leichtzumerken at gmail.com> wrote:
>
> The value is inclusive, not exclusive.
>
> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> index dc0bc550e42b..fdbe7d4e8b8b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
> @@ -3351,7 +3351,7 @@ bool amdgpu_vm_handle_fault(struct amdgpu_device *adev, unsigned int pasid,
>         }
>

Might want to add a comment here about the value being inclusive.
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

Alex

>         r = amdgpu_vm_bo_update_mapping(adev, adev, vm, true, false, NULL, addr,
> -                                       addr + 1, flags, value, NULL, NULL,
> +                                       addr, flags, value, NULL, NULL,
>                                         NULL);
>         if (r)
>                 goto error_unlock;
> --
> 2.25.1
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx