[PATCH] drm/amd/display: Fix memory leaks in S3 resume

[Harry Wentland]

It's missing the "drm_connector_list_update" call which I assume is 
important.

Stylon, can you review Lee Starnes's patch? Is the 
drm_connector_list_update call maybe not needed?

Thanks,
Harry

On 2020-11-10 11:26 a.m., Deucher, Alexander wrote:
>
> [AMD Official Use Only - Internal Distribution Only]
>
>
> Lee Starnes just sent the exact same patch yesterday.  Please review 
> that one:
> https://patchwork.freedesktop.org/patch/399497/ 
> <https://patchwork.freedesktop.org/patch/399497/>
>
> Alex
>
> ------------------------------------------------------------------------
> *From:* Wentland, Harry <Harry.Wentland at amd.com>
> *Sent:* Tuesday, November 10, 2020 9:27 AM
> *To:* Wang, Chao-kai (Stylon) <Stylon.Wang at amd.com>; 
> amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
> *Cc:* Kazlauskas, Nicholas <Nicholas.Kazlauskas at amd.com>; Deucher, 
> Alexander <Alexander.Deucher at amd.com>
> *Subject:* Re: [PATCH] drm/amd/display: Fix memory leaks in S3 resume
> On 2020-11-10 2:49 a.m., Stylon Wang wrote:
> > EDID parsing in S3 resume pushes new display modes
> > to probed_modes list but doesn't consolidate to actual
> > mode list. This creates a race condition when
> > amdgpu_dm_connector_ddc_get_modes() re-initializes the
> > list head without walking the list and results in memory leak.
> >
> > Signed-off-by: Stylon Wang <stylon.wang at amd.com>
>
> Looks reasonable to me but haven't had a chance to understand whether
> this is the best solution.
>
> Acked-by: Harry Wentland <harry.wentland at amd.com>
>
> Harry
>
> > ---
> >   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c 
> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > index 0b6adf23d316..715e0bd489f8 100644
> > --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> > @@ -2337,7 +2337,8 @@ void amdgpu_dm_update_connector_after_detect(
> >
> > drm_connector_update_edid_property(connector,
> >                                                          aconnector->edid);
> > -                     drm_add_edid_modes(connector, aconnector->edid);
> > +                     aconnector->num_modes = 
> drm_add_edid_modes(connector, aconnector->edid);
> > + drm_connector_list_update(connector);
> >
> >                        if (aconnector->dc_link->aux_mode)
> > drm_dp_cec_set_edid(&aconnector->dm_dp_aux.aux,
> >

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20201110/1309b0e4/attachment-0001.htm>