[PATCH 00/30] [Set 4] Rid W=1 warnings from GPU

Lee Jones lee.jones at linaro.org
Tue Nov 10 19:30:42 UTC 2020


This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

Exciting times (using Arm as the benchmark):

 Before these sets:
  5031 drivers/gpu/
   3923 drivers/gpu/drm/amd/
    258 drivers/gpu/drm/radeon/
     95 drivers/gpu/drm/nouveau/
     77 drivers/gpu/drm/msm/

 After these sets:
  2236 drivers/gpu/
    1949 drivers/gpu/drm/amd/
      97 drivers/gpu/drm/nouveau/
      83 drivers/gpu/drm/msm/
      40 drivers/gpu/drm/radeon

Couple more to go.

Plan is to finsish off Radeon, then start targeting AMD tomorrow.

Lee Jones (30):
  drm/radeon/evergreen: Add comment for 'evergreen_page_flip()'s 'async'
    param
  drm/radeon/evergreen: Remove set but unused variable 'mc_shared_chmap'
  drm/radeon/ni: Demote vague attempt at function header doc
  drm/radeon/si: Remove set but unused variable 'mc_shared_chmap'
  drm/radeon/cik: Remove set but unused variable 'mc_shared_chmap'
  drm/radeon/trinity_dpm: Remove some defined but never used arrays
  drm/radeon/kv_dpm: Strip out unused functions and their tables
  drm/radeon/ci_dpm: Remove set but unused variable 'dpm_event_src'
  drm/radeon/radeon_vm: Fix some function parameter documentation
  drm/radeon/radeon_sync: Add description for function param 'rdev'
  drm/radeon/radeon_ib: Supply description for 'radeon_ib_get's get
    param
  drm/radeon/radeon_dp_mst: Remove unused variable 'ret' from
    radeon_mst_encoder_dpms()
  drm/radeon/radeon_mn: Supply description for 'cur_seq' even if it is
    unused
  drm/radeon/evergreen_dma: Fix doc-rot of function parameter 'resv'
  drm/radeon/cik_sdma: Demote vague attempt at kernel-doc
  drm/radeon/r100: Fix some kernel-doc formatting, misnaming and missing
    issues
  drm/radeon/r600_cs: Fix some doc-rot and supply missing function param
    docs
  drm/radeon/evergreen_cs: Fix misnaming issues surrounding 'p' param
  drm/radeon/radeon_drv: Move 'radeon_mmap()'s prototype to shared
    header
  drm/radeon/radeon_drv: Move 'radeon_driver_irq_handler_kms's prototype
    into shared header
  drm/radeon/atom: Move 'radeon_atom_hw_i2c_*()'s prototypes into shared
    header
  drm/radeon/radeon_gem: Move 'radeon_gem_prime_*()'s prototypes to
    shared header
  drm/radeon/evergreen_hdmi: Move 'evergreen_*()' and 'dce4_*()' HDMI
    prototypes to shared header
  drm/radeon/rv770: Move 'rv770_get_*()'s prototypes to shared header
  drm/radeon/sumo_dpm: Move 'sumo_get_pi()'s prototype into shared
    header
  drm/radeon/ni_dpm: Move 'ni_get_{pi,ps}()'s into shared header
  drm/radeon/ni: Remove set but unused variable 'mc_shared_chmap'
  drm/radeon/evergreen: Move 'cayman_*()'s prototypes to shared header
  drm/radeon/r600_dma: Move 'r600_gpu_check_soft_reset()'s prototype to
    shared location
  drm/radeon/cik: Move 'r600_ih_ring_{alloc,fini}()'s prototypes to
    shared header

 drivers/gpu/drm/radeon/atom.h           |   6 +
 drivers/gpu/drm/radeon/btc_dpm.c        |   3 +-
 drivers/gpu/drm/radeon/ci_dpm.c         |  12 --
 drivers/gpu/drm/radeon/cik.c            |   7 +-
 drivers/gpu/drm/radeon/cik_sdma.c       |   4 +-
 drivers/gpu/drm/radeon/cypress_dpm.c    |   3 +-
 drivers/gpu/drm/radeon/evergreen.c      |  10 +-
 drivers/gpu/drm/radeon/evergreen_cs.c   |   6 +-
 drivers/gpu/drm/radeon/evergreen_dma.c  |   2 +-
 drivers/gpu/drm/radeon/evergreen_hdmi.c |   1 +
 drivers/gpu/drm/radeon/evergreen_hdmi.h |  69 ++++++++
 drivers/gpu/drm/radeon/kv_dpm.c         | 205 +-----------------------
 drivers/gpu/drm/radeon/ni.c             |   9 +-
 drivers/gpu/drm/radeon/ni.h             |  36 +++++
 drivers/gpu/drm/radeon/ni_dpm.c         |   2 +-
 drivers/gpu/drm/radeon/ni_dpm.h         |   3 +
 drivers/gpu/drm/radeon/r100.c           |   7 +-
 drivers/gpu/drm/radeon/r600.c           |   1 +
 drivers/gpu/drm/radeon/r600.h           |  35 ++++
 drivers/gpu/drm/radeon/r600_cs.c        |   9 +-
 drivers/gpu/drm/radeon/r600_dma.c       |   3 +-
 drivers/gpu/drm/radeon/radeon_audio.c   |  26 +--
 drivers/gpu/drm/radeon/radeon_dp_mst.c  |  16 +-
 drivers/gpu/drm/radeon/radeon_drv.c     |   7 +-
 drivers/gpu/drm/radeon/radeon_gem.c     |   9 +-
 drivers/gpu/drm/radeon/radeon_i2c.c     |   4 -
 drivers/gpu/drm/radeon/radeon_ib.c      |   1 +
 drivers/gpu/drm/radeon/radeon_irq_kms.c |   1 +
 drivers/gpu/drm/radeon/radeon_kms.h     |   5 +
 drivers/gpu/drm/radeon/radeon_mn.c      |   1 +
 drivers/gpu/drm/radeon/radeon_prime.c   |   1 +
 drivers/gpu/drm/radeon/radeon_prime.h   |  39 +++++
 drivers/gpu/drm/radeon/radeon_sync.c    |   1 +
 drivers/gpu/drm/radeon/radeon_ttm.h     |   1 +
 drivers/gpu/drm/radeon/radeon_vm.c      |   8 +-
 drivers/gpu/drm/radeon/rv730_dpm.c      |   4 +-
 drivers/gpu/drm/radeon/rv740_dpm.c      |   3 +-
 drivers/gpu/drm/radeon/rv770.h          |   5 +
 drivers/gpu/drm/radeon/rv770_dpm.c      |   1 +
 drivers/gpu/drm/radeon/si.c             |   7 +-
 drivers/gpu/drm/radeon/si_dpm.c         |   5 +-
 drivers/gpu/drm/radeon/sumo_dpm.h       |   1 +
 drivers/gpu/drm/radeon/sumo_smc.c       |   2 -
 drivers/gpu/drm/radeon/trinity_dpm.c    |  44 -----
 44 files changed, 261 insertions(+), 364 deletions(-)
 create mode 100644 drivers/gpu/drm/radeon/evergreen_hdmi.h
 create mode 100644 drivers/gpu/drm/radeon/ni.h
 create mode 100644 drivers/gpu/drm/radeon/r600.h
 create mode 100644 drivers/gpu/drm/radeon/radeon_prime.h

Cc: Alex Deucher <alexander.deucher at amd.com>
Cc: amd-gfx at lists.freedesktop.org
Cc: "Christian König" <christian.koenig at amd.com>
Cc: Daniel Vetter <daniel at ffwll.ch>
Cc: David Airlie <airlied at linux.ie>
Cc: dri-devel at lists.freedesktop.org
Cc: Evan Quan <evan.quan at amd.com>
Cc: Gareth Hughes <gareth at valinux.com>
Cc: linaro-mm-sig at lists.linaro.org
Cc: linux-media at vger.kernel.org
Cc: Sumit Semwal <sumit.semwal at linaro.org>
-- 
2.25.1



More information about the amd-gfx mailing list