[PATCH 00/40] [Set 7] Rid W=1 warnings from GPU

Lee Jones lee.jones at linaro.org
Fri Nov 13 13:48:58 UTC 2020


This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.

This brings the running total from 5000 (in v5.9) down to 1400!

Hopefully not too much more to go now.

Lee Jones (40):
  drm/amd/include/vega10_ip_offset: Mark _BASE structs as __maybe_unused
  drm/amd/display/dc/core/dc_link_dp: Move
    DP_VGA_LVDS_CONVERTER_ID_{2,3} to where they're used
  drm/amd/display/dc/core/dc_link_ddc: Move DP_DVI_CONVERTER_ID_{4,5} to
    where they're used
  drm/amd/amdgpu/amdgpu_drv: Move 'amdgpu_info_ioctl()'s prototype to
    shared header
  drm/amd/amdgpu/amdgpu_ring: Fix misnaming of param 'max_dw'
  drm/msm/adreno/a6xx_gpu: Staticise local function 'a6xx_idle'
  drm/mediatek/mtk_disp_rdma: Fix formatting and supply missing struct
    member description
  drm/amd/amdgpu/amdgpu_ib: Fix some incorrect/incomplete function
    documentation
  drm/mediatek/mtk_drm_crtc: Demote seriously out-of-date struct header
  drm/mediatek/mtk_drm_drv: Staticise local function invoked by
    reference
  drm/amd/amdgpu/amdgpu_pll: Fix kernel-doc formatting, missing and
    extra params
  drm/pl111/pl111_display: Make local function static
  drm/panel/panel-tpo-tpg110: Correct misnaming and supply missing param
    description
  drm/meson/meson_venc: Make local function
    'meson_venc_hdmi_get_dmt_vmode' static
  drm/lima/lima_drv: Demote kernel-doc formatting abuse
  drm/amd/amdgpu/amdgpu_sync: Fix misnamed, missing and extra param
    descriptions
  drm/meson/meson_vclk: Make two local functions static
  drm/mediatek/mtk_dpi: Remove unused struct definition
    'mtk_dpi_encoder_funcs'
  drm/amd/amdgpu/amdgpu_vram_mgr: Add missing descriptions for 'dev' and
    'dir'
  drm/pl111/pl111_debugfs: Make local function 'pl111_debugfs_regs()'
    static
  drm/amd/amdgpu/amdgpu_virt: Make local function
    'amdgpu_virt_update_vf2pf_work_item()' static
  drm/amd/amdgpu/amdgpu_sched: Consume our own header containing
    prototypes
  drm/lima/lima_sched: Remove unused and unnecessary variable 'ret'
  drm/amd/amdgpu/amdgpu_ids: Supply missing docs for 'id' and 'vmhub'
  drm/amd/amdgpu/amdgpu_debugfs: Demote obvious abuse of kernel-doc
    formatting
  drm/amd/amdgpu/amdgpu_gmc: Demote one and fix another function header
  drm/amd/amdgpu/amdgpu_ras: Remove unused function
    'amdgpu_ras_error_cure'
  drm/amd/amdgpu/amdgpu_ras: Make local function
    'amdgpu_ras_error_status_query' static
  drm/amd/amdgpu/amdgpu_csa: Remove set but unused variable 'r'
  drm/amd/amdgpu/amdgpu_vm_cpu: Fix 'amdgpu_vm_cpu_prepare()'s doc-rot
  drm/amd/amdgpu/amdgpu_vm_sdma: Fix 'amdgpu_vm_sdma_prepare()'s doc-rot
  drm/msm/disp/mdp5/mdp5_crtc: Make local function
    'mdp5_crtc_setup_pipeline()' static
  drm/drm_dp_mst_topology: Remove set but never used variable 'len'
  drm/msm/disp/mdp5/mdp5_ctl: Demote non-conformant kernel-doc headers
  drm/msm/disp/mdp5/mdp5_kms: Make local functions 'mdp5_{en,dis}able()'
    static
  drm/amd/amdgpu/amdgpu_fw_attestation: Consume our own header
    containing prototypes
  drm/amd/amdgpu/smu_v11_0_i2c: Provide descriptions for 'control' and
    'data' params
  drm/msm/disp/dpu1/dpu_core_perf: Remove set but unused variable
    'dpu_cstate'
  drm/msm/disp/dpu1/dpu_encoder: Remove a bunch of unused variables
  drm/amd/amdgpu/gfx_v7_0: Remove unused struct definition

 drivers/gpu/drm/amd/amdgpu/amdgpu_csa.c       |  3 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_debugfs.c   |  4 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c       |  4 +-
 .../drm/amd/amdgpu/amdgpu_fw_attestation.c    |  3 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c       |  5 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_ib.c        |  6 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c       |  2 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_kms.c       |  1 +
 drivers/gpu/drm/amd/amdgpu/amdgpu_kms.h       | 31 ++++++++
 drivers/gpu/drm/amd/amdgpu/amdgpu_pll.c       | 10 +--
 drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c       | 11 +--
 drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c      |  2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_sched.c     |  2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c      |  4 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c      |  2 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm_cpu.c    |  4 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_vm_sdma.c   |  4 +-
 drivers/gpu/drm/amd/amdgpu/amdgpu_vram_mgr.c  |  2 +
 drivers/gpu/drm/amd/amdgpu/gfx_v7_0.c         |  9 ---
 drivers/gpu/drm/amd/amdgpu/gfx_v7_0.h         |  1 -
 drivers/gpu/drm/amd/amdgpu/smu_v11_0_i2c.c    |  3 +
 .../gpu/drm/amd/display/dc/core/dc_link_ddc.c |  4 +
 .../gpu/drm/amd/display/dc/core/dc_link_dp.c  |  5 ++
 .../amd/display/include/ddc_service_types.h   |  8 --
 .../gpu/drm/amd/include/vega10_ip_offset.h    | 76 +++++++++----------
 drivers/gpu/drm/drm_dp_mst_topology.c         |  4 +-
 drivers/gpu/drm/lima/lima_drv.c               |  2 +-
 drivers/gpu/drm/lima/lima_sched.c             |  3 +-
 drivers/gpu/drm/mediatek/mtk_disp_rdma.c      |  5 +-
 drivers/gpu/drm/mediatek/mtk_dpi.c            |  9 ---
 drivers/gpu/drm/mediatek/mtk_drm_crtc.c       |  4 +-
 drivers/gpu/drm/mediatek/mtk_drm_drv.c        |  4 +-
 drivers/gpu/drm/meson/meson_vclk.c            |  8 +-
 drivers/gpu/drm/meson/meson_venc.c            |  4 +-
 drivers/gpu/drm/msm/adreno/a6xx_gpu.c         |  2 +-
 drivers/gpu/drm/msm/disp/dpu1/dpu_core_perf.c |  3 -
 drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c   | 12 +--
 drivers/gpu/drm/msm/disp/mdp5/mdp5_crtc.c     |  6 +-
 drivers/gpu/drm/msm/disp/mdp5/mdp5_ctl.c      |  6 +-
 drivers/gpu/drm/msm/disp/mdp5/mdp5_kms.c      |  4 +-
 drivers/gpu/drm/panel/panel-tpo-tpg110.c      |  3 +-
 drivers/gpu/drm/pl111/pl111_debugfs.c         |  2 +-
 drivers/gpu/drm/pl111/pl111_display.c         |  2 +-
 43 files changed, 147 insertions(+), 142 deletions(-)
 create mode 100644 drivers/gpu/drm/amd/amdgpu/amdgpu_kms.h

Cc: Alex Deucher <alexander.deucher at amd.com>
Cc: amd-gfx at lists.freedesktop.org
Cc: Andres Rodriguez <andresx7 at gmail.com>
Cc: "Christian König" <christian.koenig at amd.com>
Cc: Chun-Kuang Hu <chunkuang.hu at kernel.org>
Cc: Daniel Vetter <daniel at ffwll.ch>
Cc: David Airlie <airlied at linux.ie>
Cc: dri-devel at lists.freedesktop.org
Cc: Eric Anholt <eric at anholt.net>
Cc: Felix Kuehling <Felix.Kuehling at amd.com>
Cc: freedreno at lists.freedesktop.org
Cc: Harry Wentland <harry.wentland at amd.com>
Cc: Hawking Zhang <Hawking.Zhang at amd.com>
Cc: Jerome Brunet <jbrunet at baylibre.com>
Cc: Jie Qiu <jie.qiu at mediatek.com>
Cc: John Clements <john.clements at amd.com>
Cc: Kalyan Thota <kalyan_t at codeaurora.org>
Cc: Kevin Hilman <khilman at baylibre.com>
Cc: Leo Li <sunpeng.li at amd.com>
Cc: lima at lists.freedesktop.org
Cc: linaro-mm-sig at lists.linaro.org
Cc: Linus Walleij <linus.walleij at linaro.org>
Cc: linux-amlogic at lists.infradead.org
Cc: linux-arm-kernel at lists.infradead.org
Cc: linux-arm-msm at vger.kernel.org
Cc: linux-mediatek at lists.infradead.org
Cc: linux-media at vger.kernel.org
Cc: Luben Tuikov <luben.tuikov at amd.com>
Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
Cc: Martin Blumenstingl <martin.blumenstingl at googlemail.com>
Cc: Matthias Brugger <matthias.bgg at gmail.com>
Cc: Maxime Ripard <mripard at kernel.org>
Cc: Monk.liu at amd.com
Cc: Neil Armstrong <narmstrong at baylibre.com>
Cc: Philipp Zabel <p.zabel at pengutronix.de>
Cc: Qiang Yu <yuq825 at gmail.com>
Cc: Rob Clark <robdclark at gmail.com>
Cc: Sam Ravnborg <sam at ravnborg.org>
Cc: Sean Paul <sean at poorly.run>
Cc: Sumit Semwal <sumit.semwal at linaro.org>
Cc: Thierry Reding <thierry.reding at gmail.com>
Cc: Thomas Zimmermann <tzimmermann at suse.de>
Cc: YT SHEN <yt.shen at mediatek.com>
-- 
2.25.1



More information about the amd-gfx mailing list