[PATCH 4/4] drm/amd/display: don't expose rotation prop for cursor plane

[Alex Deucher]

On Fri, Nov 20, 2020 at 3:19 PM Simon Ser <contact at emersion.fr> wrote:
>
> Setting any rotation on the cursor plane is ignored by amdgpu.
> Because of DCE/DCN design, it's not possible to rotate the cursor.
> Instead of displaying the wrong result, stop advertising the rotation
> property for the cursor plane.
>
> Now that we check all cursor plane properties in amdgpu_dm_atomic_check,
> remove the TODO.
>
> Signed-off-by: Simon Ser <contact at emersion.fr>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Cc: Harry Wentland <hwentlan at amd.com>
> Cc: Nicholas Kazlauskas <nicholas.kazlauskas at amd.com>

Applied the series.  Thanks!

Alex


> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index 2542571a8993..3283e22241d7 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -6592,7 +6592,8 @@ static int amdgpu_dm_plane_init(struct amdgpu_display_manager *dm,
>                 DRM_MODE_ROTATE_0 | DRM_MODE_ROTATE_90 |
>                 DRM_MODE_ROTATE_180 | DRM_MODE_ROTATE_270;
>
> -       if (dm->adev->asic_type >= CHIP_BONAIRE)
> +       if (dm->adev->asic_type >= CHIP_BONAIRE &&
> +           plane->type != DRM_PLANE_TYPE_CURSOR)
>                 drm_plane_create_rotation_property(plane, DRM_MODE_ROTATE_0,
>                                                    supported_rotations);
>
> @@ -8887,7 +8888,6 @@ static int dm_update_plane_state(struct dc *dc,
>         dm_new_plane_state = to_dm_plane_state(new_plane_state);
>         dm_old_plane_state = to_dm_plane_state(old_plane_state);
>
> -       /*TODO Implement better atomic check for cursor plane */
>         if (plane->type == DRM_PLANE_TYPE_CURSOR) {
>                 if (!enable || !new_plane_crtc ||
>                         drm_atomic_plane_disabling(plane->state, new_plane_state))
> --
> 2.29.2
>
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx