[PATCH] drm/amdgpu: default noretry=0 for navi1x and newer

[Alex Deucher]

On Mon, Nov 30, 2020 at 2:25 PM Felix Kuehling <felix.kuehling at amd.com> wrote:
>
> Am 2020-11-30 um 1:58 p.m. schrieb Alex Deucher:
> > There are no performance advantages to setting it to 1 and
> > it causes stability issues in some cases.
> >
> > Bug: https://gitlab.freedesktop.org/drm/amd/-/issues/1374
> > Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> > ---
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> > index fede84509dbc..02b2ee9b8939 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gmc.c
> > @@ -422,11 +422,6 @@ void amdgpu_gmc_noretry_set(struct amdgpu_device *adev)
> >
> >       switch (adev->asic_type) {
> >       case CHIP_VEGA20:
> > -     case CHIP_NAVI10:
> > -     case CHIP_NAVI14:
> > -     case CHIP_SIENNA_CICHLID:
> > -     case CHIP_NAVY_FLOUNDER:
> > -     case CHIP_DIMGREY_CAVEFISH:
> >               /*
> >                * noretry = 0 will cause kfd page fault tests fail
> >                * for some ASICs, so set default to 1 for these ASICs.
> > @@ -437,6 +432,11 @@ void amdgpu_gmc_noretry_set(struct amdgpu_device *adev)
> >                       gmc->noretry = amdgpu_noretry;
> >               break;
> >       case CHIP_RAVEN:
> > +     case CHIP_NAVI10:
> > +     case CHIP_NAVI14:
> > +     case CHIP_SIENNA_CICHLID:
> > +     case CHIP_NAVY_FLOUNDER:
> > +     case CHIP_DIMGREY_CAVEFISH:
>
> Is there any point listing those chips here explicitly, given that it's
> the default case? Anyway, the patch is

Just noticed that myself and sent a v2.

Alex

>
> Acked-by: Felix Kuehling <Felix.Kuehling at amd.com>
>
> >       default:
> >               /* Raven currently has issues with noretry
> >                * regardless of what we decide for other
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx