[PATCH] drm/amd/display: Add missing function pointers for dcn3

Kazlauskas, Nicholas nicholas.kazlauskas at amd.com
Mon Oct 5 18:12:51 UTC 2020


On 2020-10-05 2:10 p.m., Bhawanpreet Lakha wrote:
> These function pointers are missing from dcn30_init
> 
> .calc_vupdate_position
> .set_pipe
> 
> So add them
> 
> Signed-off-by: Bhawanpreet Lakha <Bhawanpreet.Lakha at amd.com>

Reviewed-by: Nicholas Kazlauskas <nicholas.kazlauskas at amd.com>

Would be good to mention what these are used for specifically though.

The calc_vupdate_position in particular is used to help avoid cursor 
stuttering.

Regards,
Nicholas Kazlauskas

> ---
>   drivers/gpu/drm/amd/display/dc/dcn30/dcn30_init.c | 2 ++
>   1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_init.c b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_init.c
> index 7c90c2222506..dc312d4172af 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_init.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_init.c
> @@ -90,9 +90,11 @@ static const struct hw_sequencer_funcs dcn30_funcs = {
>   	.init_vm_ctx = dcn20_init_vm_ctx,
>   	.set_flip_control_gsl = dcn20_set_flip_control_gsl,
>   	.get_vupdate_offset_from_vsync = dcn10_get_vupdate_offset_from_vsync,
> +	.calc_vupdate_position = dcn10_calc_vupdate_position,
>   	.apply_idle_power_optimizations = dcn30_apply_idle_power_optimizations,
>   	.set_backlight_level = dcn21_set_backlight_level,
>   	.set_abm_immediate_disable = dcn21_set_abm_immediate_disable,
> +	.set_pipe = dcn21_set_pipe,
>   };
>   
>   static const struct hwseq_private_funcs dcn30_private_funcs = {
> 



More information about the amd-gfx mailing list