[PATCH 2/2] drm/amd/display: Avoid MST manager resource leak.

[Alex Deucher]

On Wed, Oct 14, 2020 at 1:25 PM Andrey Grodzovsky
<andrey.grodzovsky at amd.com> wrote:
>
> On connector destruction call drm_dp_mst_topology_mgr_destroy
> to release resources allocated in drm_dp_mst_topology_mgr_init.
> Do it only if MST manager was initialized before otherwsie a crash
> is seen on driver unload/device unplug.
>

Not really an mst expert, but this seems to match what i915 and
nouveau do.  Series is:
Acked-by: Alex Deucher <alexander.deucher at amd.com>

> Signed-off-by: Andrey Grodzovsky <andrey.grodzovsky at amd.com>
> ---
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> index a72447d..64799c4 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c
> @@ -5170,6 +5170,13 @@ static void amdgpu_dm_connector_destroy(struct drm_connector *connector)
>         struct amdgpu_device *adev = drm_to_adev(connector->dev);
>         struct amdgpu_display_manager *dm = &adev->dm;
>
> +       /*
> +        * Call only if mst_mgr was initialized before since it's not done
> +        * for all connector types.
> +        */
> +       if (aconnector->mst_mgr.dev)
> +               drm_dp_mst_topology_mgr_destroy(&aconnector->mst_mgr);
> +
>  #if defined(CONFIG_BACKLIGHT_CLASS_DEVICE) ||\
>         defined(CONFIG_BACKLIGHT_CLASS_DEVICE_MODULE)
>
> --
> 2.7.4
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx