[PATCH] drm/amdkfd: Use same SQ prefetch setting as amdgpu

Felix Kuehling felix.kuehling at amd.com
Mon Oct 19 16:22:43 UTC 2020


Am 2020-10-19 um 10:02 a.m. schrieb Jay Cornwall:
> 0 causes instruction fetch stall at cache line boundary under some
> conditions on Navi10. A non-zero prefetch is the preferred default
> in any case.
>
> Fixes soft hang in Luxmark.
>
> Signed-off-by: Jay Cornwall <jay.cornwall at amd.com>

Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com>


> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_v10.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_v10.c b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_v10.c
> index 72e4d61ac752..ad0593342333 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_v10.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_device_queue_manager_v10.c
> @@ -58,8 +58,9 @@ static int update_qpd_v10(struct device_queue_manager *dqm,
>  	/* check if sh_mem_config register already configured */
>  	if (qpd->sh_mem_config == 0) {
>  		qpd->sh_mem_config =
> -				SH_MEM_ALIGNMENT_MODE_UNALIGNED <<
> -					SH_MEM_CONFIG__ALIGNMENT_MODE__SHIFT;
> +			(SH_MEM_ALIGNMENT_MODE_UNALIGNED <<
> +				SH_MEM_CONFIG__ALIGNMENT_MODE__SHIFT) |
> +			(3 << SH_MEM_CONFIG__INITIAL_INST_PREFETCH__SHIFT);
>  #if 0
>  		/* TODO:
>  		 *    This shouldn't be an issue with Navi10.  Verify.


More information about the amd-gfx mailing list