[PATCH] drm/amdgpu/display: use kvzalloc again in dc_create_state

Alex Xu (Hello71) alex_y_xu at yahoo.ca
Mon Oct 26 16:56:07 UTC 2020


Excerpts from Alex Deucher's message of October 26, 2020 10:30 am:
> It looks this was accidently lost in a follow up patch.
> dc context is large and we don't need contiguous pages.
> 
> Fixes: e4863f118a7d ("drm/amd/display: Multi display cause system lag on mode change")
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> Cc: Aric Cyr <aric.cyr at amd.com>
> Cc: Alex Xu <alex_y_xu at yahoo.ca>
> ---
>  drivers/gpu/drm/amd/display/dc/core/dc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
> index 7ff029143722..64da60450fb0 100644
> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
> @@ -1564,8 +1564,8 @@ static void init_state(struct dc *dc, struct dc_state *context)
>  
>  struct dc_state *dc_create_state(struct dc *dc)
>  {
> -	struct dc_state *context = kzalloc(sizeof(struct dc_state),
> -					   GFP_KERNEL);
> +	struct dc_state *context = kvzalloc(sizeof(struct dc_state),
> +					    GFP_KERNEL);
>  
>  	if (!context)
>  		return NULL;
> -- 
> 2.25.4
> 
> 

Did a quick test, it seems to resolve the issue for me. If you could 
apply one or both of:

Reported-by: Alex Xu (Hello71) <alex_y_xu at yahoo.ca>
Tested-by: Alex Xu (Hello71) <alex_y_xu at yahoo.ca>

I'd appreciate it, but it's not a big deal. Thanks!


More information about the amd-gfx mailing list