[PATCH 1/1] drm/amdgpu: disable gpu-sched load balance for uvd

Nirmoy nirmodas at amd.com
Tue Sep 1 07:50:39 UTC 2020


On 9/1/20 9:07 AM, Paul Menzel wrote:
> Dear Nirmoy,
>
>
> Am 31.08.20 um 12:45 schrieb Nirmoy Das:
>> UVD dependent jobs should run on the same udv instance.
>
> Why? Datasheet? Performance reasons? What happens if they do not run 
> on the UVD instance? Are there bug reports?


Sorry about that, I should've elaborated more. I will take care of that 
in my next patch.


Nirmoy


>
> It’d be great if you extended the commit message.
>
>> This patch disables gpu scheduler's load balancer for
>> a context which binds jobs from same the context to a udv
>> instance.
>>
>> Signed-off-by: Nirmoy Das <nirmoy.das at amd.com>
>> ---
>>   drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c 
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
>> index 59032c26fc82..7cd398d25498 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ctx.c
>> @@ -114,7 +114,9 @@ static int amdgpu_ctx_init_entity(struct 
>> amdgpu_ctx *ctx, u32 hw_ip,
>>       scheds = adev->gpu_sched[hw_ip][hw_prio].sched;
>>       num_scheds = adev->gpu_sched[hw_ip][hw_prio].num_scheds;
>>
>> -    if (hw_ip == AMDGPU_HW_IP_VCN_ENC || hw_ip == 
>> AMDGPU_HW_IP_VCN_DEC) {
>> +    if (hw_ip == AMDGPU_HW_IP_VCN_ENC ||
>> +        hw_ip == AMDGPU_HW_IP_VCN_DEC ||
>> +        hw_ip == AMDGPU_HW_IP_UVD) {
>>           sched = drm_sched_pick_best(scheds, num_scheds);
>>           scheds = &sched;
>>           num_scheds = 1;
>
>
> Kind regards,
>
> Paul


More information about the amd-gfx mailing list