[PATCH 9/9] drm/amd/pm: make namings and comments more readable

Alex Deucher alexdeucher at gmail.com
Thu Sep 3 13:41:02 UTC 2020


On Wed, Sep 2, 2020 at 4:32 AM Evan Quan <evan.quan at amd.com> wrote:
>
> And to fit more accurately what the cod does.
>
> Change-Id: I2d917e66b55925c3a14aa96ac8e0c8c2110848c0
> Signed-off-by: Evan Quan <evan.quan at amd.com>

Series is:
Reviewed-by: Alex Deucher <alexander.deucher at amd.com>

> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
> index 801c92eb439f..cd5394d4beb0 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/navi10_ppt.c
> @@ -2185,7 +2185,7 @@ static int navi10_run_btc(struct smu_context *smu)
>         return ret;
>  }
>
> -static bool navi10_need_umc_cdr_12gbps_workaround(struct smu_context *smu)
> +static bool navi10_need_umc_cdr_workaround(struct smu_context *smu)
>  {
>         struct amdgpu_device *adev = smu->adev;
>
> @@ -2276,7 +2276,7 @@ static int navi10_set_dummy_pstates_table_location(struct smu_context *smu)
>                                                NULL);
>  }
>
> -static int navi10_disable_umc_cdr_12gbps_workaround(struct smu_context *smu)
> +static int navi10_run_umc_cdr_workaround(struct smu_context *smu)
>  {
>         struct amdgpu_device *adev = smu->adev;
>         uint8_t umc_fw_greater_than_v136 = false;
> @@ -2284,7 +2284,7 @@ static int navi10_disable_umc_cdr_12gbps_workaround(struct smu_context *smu)
>         uint32_t param;
>         int ret = 0;
>
> -       if (!navi10_need_umc_cdr_12gbps_workaround(smu))
> +       if (!navi10_need_umc_cdr_workaround(smu))
>                 return 0;
>
>         ret = smu_cmn_send_smc_msg_with_param(smu,
> @@ -2655,7 +2655,7 @@ static int navi10_post_smu_init(struct smu_context *smu)
>                 return ret;
>         }
>
> -       ret = navi10_disable_umc_cdr_12gbps_workaround(smu);
> +       ret = navi10_run_umc_cdr_workaround(smu);
>         if (ret)
>                 dev_err(adev->dev, "Failed to apply umc cdr workaround!\n");
>
> --
> 2.28.0
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx


More information about the amd-gfx mailing list