[PATCH v2 04/11] drm/fourcc: Add AMD DRM modifiers.

[Pierre-Eric Pelloux-Prayer]

Hi Bas,

2 small typos you may want to fix:

On 04/09/2020 18:07, Bas Nieuwenhuizen wrote:
> This adds modifiers for GFX9+ AMD GPUs.
> 
> As the modifiers need a lot of parameters I split things out in
> getters and setters.
>   - Advantage: simplifies the code a lot
>   - Disadvantage: Makes it harder to check that you're setting all
>                   the required fields.
> 
> The tiling modes seem to change every generatio, but the structure

"generatio" -> "generation"

> of what each tiling mode is good for stays really similar. As such
> the core of the modifier is
>  - the tiling mode
>  - a version. Not explicitly a GPU generation, but splitting out
>    a new set of tiling equations.

[...]
> + * with DCC & DCC_RETILE:
> + *   - main surface in plane 0
> + *   - displayable DCC surface in plane 1 (not RB-aligned & not pipe-aligned)
> + *   - pipe-aligned DCC surface in plane 2 (RB-aligned & pipe-aligned)
> + *
> + * For multi-plane formats the above surfaces get merged into one plane for
> + * each for format plane, based on the required alignment only.

"for each for format plane" => "for each format plane"?


Pierre-Eric