[PATCH] drm/radeon: revert "Prefer lower feedback dividers"

Christian König ckoenig.leichtzumerken at gmail.com
Fri Sep 11 07:35:44 UTC 2020


Ping, we need to revert this ASAP.

Christian.

Am 09.09.20 um 13:16 schrieb Christian König:
> Turns out this breaks a lot of different hardware.
>
> This reverts commit 522ff3a8b6d73a31084b4b087b458f7fa0ac1e14.
>
> Signed-off-by: Christian König <christian.koenig at amd.com>
> ---
>   drivers/gpu/drm/radeon/radeon_display.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/radeon/radeon_display.c b/drivers/gpu/drm/radeon/radeon_display.c
> index 7b69d6dfe44a..e0ae911ef427 100644
> --- a/drivers/gpu/drm/radeon/radeon_display.c
> +++ b/drivers/gpu/drm/radeon/radeon_display.c
> @@ -933,7 +933,7 @@ static void avivo_get_fb_ref_div(unsigned nom, unsigned den, unsigned post_div,
>   
>   	/* get matching reference and feedback divider */
>   	*ref_div = min(max(den/post_div, 1u), ref_div_max);
> -	*fb_div = max(nom * *ref_div * post_div / den, 1u);
> +	*fb_div = DIV_ROUND_CLOSEST(nom * *ref_div * post_div, den);
>   
>   	/* limit fb divider to its maximum */
>   	if (*fb_div > fb_div_max) {



More information about the amd-gfx mailing list