[PATCH v2 0/3] Refactor DM IRQ handling

Aurabindo Pillai aurabindo.pillai at amd.com
Fri Sep 11 16:27:06 UTC 2020


Changes in V2:
 * fix memory leak.

Interrupts are disabled too early in DM's atomic_commit() which can
cause issues in certain situations with non blocking commits timing
out on flip_done interrupt. The early disabling of interrupts were
necessary due to interrupts accessing crtc state directly. This
refactor removes direct access of crtc state from the irq handler
so that disabling of interrupts can be done later in commit_tail()

--

Aurabindo Pillai (3):
  drm/amdgpu: Move existing pflip fields into separate struct
  drm/amd/display: Refactor to prevent crtc state access in DM IRQ
    handler
  drm/amd/display: Move disable interrupt into commit tail

 drivers/gpu/drm/amd/amdgpu/amdgpu_mode.h      |   4 +-
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 156 +++++++++---------
 .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.h |   1 -
 .../display/amdgpu_dm/amdgpu_dm_irq_params.h  |  37 +++++
 4 files changed, 115 insertions(+), 83 deletions(-)
 create mode 100644 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_irq_params.h

-- 
2.25.1



More information about the amd-gfx mailing list