[PATCH] drm/amdgpu: Update RAS init handling

[Deucher, Alexander]

[AMD Public Use]

Also, general nit, per kernel coding style, braces should be on the same line as the if or else,  E.g.,
} else {


Alex
________________________________
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of Zhang, Hawking <Hawking.Zhang at amd.com>
Sent: Friday, September 11, 2020 2:02 AM
To: Clements, John <John.Clements at amd.com>; amd-gfx list <amd-gfx at lists.freedesktop.org>; Chen, Guchun <Guchun.Chen at amd.com>
Subject: RE: [PATCH] drm/amdgpu: Update RAS init handling


[AMD Public Use]



+                             {

+                                             dev_warn(psp->adev->dev, "RAS Init Status: 0x%X\n", ras_cmd->ras_status);

+                             }

Please remove the redundant bracket.



Other than that, the patch is

Reviewed-by: Hawking Zhang <Hawking.Zhang at amd.com>



In addition, please create another patch to move the nbio ras controller irq source registry to sw_init, which is the consistent as what we did for other ip blocks, register the irq source in IP sw_init funcs.



Regards,

Hawking

From: Clements, John <John.Clements at amd.com>
Sent: Friday, September 11, 2020 12:03
To: amd-gfx list <amd-gfx at lists.freedesktop.org>; Chen, Guchun <Guchun.Chen at amd.com>; Zhang, Hawking <Hawking.Zhang at amd.com>
Subject: [PATCH] drm/amdgpu: Update RAS init handling



[AMD Official Use Only - Internal Distribution Only]



Added RAS status check and tear down RAS context if RAS init fails
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20200914/3c9ed728/attachment.htm>