[PATCH] drm/amd/display: Don't log hdcp module warnings in dmesg

Rodrigo Siqueira Rodrigo.Siqueira at amd.com
Tue Sep 15 22:23:57 UTC 2020


On 09/15, Bhawanpreet Lakha wrote:
> [Why]
> DTM topology updates happens by default now. This results in DTM
> warnings when hdcp is not even being enabled. This spams the dmesg
> and doesn't effect normal display functionality so it is better to log it
> using DRM_DEBUG_KMS()
> 
> [How]
> Change the DRM_WARN() to DRM_DEBUG_KMS()
> 
> Signed-off-by: Bhawanpreet Lakha <Bhawanpreet.Lakha at amd.com>
> ---
>  drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.h b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.h
> index d3192b9d0c3d..47f8ee2832ff 100644
> --- a/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.h
> +++ b/drivers/gpu/drm/amd/display/modules/hdcp/hdcp_log.h
> @@ -27,7 +27,7 @@
>  #define MOD_HDCP_LOG_H_
>  
>  #ifdef CONFIG_DRM_AMD_DC_HDCP
> -#define HDCP_LOG_ERR(hdcp, ...) DRM_WARN(__VA_ARGS__)
> +#define HDCP_LOG_ERR(hdcp, ...) DRM_DEBUG_KMS(__VA_ARGS__)
>  #define HDCP_LOG_VER(hdcp, ...) DRM_DEBUG_KMS(__VA_ARGS__)
>  #define HDCP_LOG_FSM(hdcp, ...) DRM_DEBUG_KMS(__VA_ARGS__)
>  #define HDCP_LOG_TOP(hdcp, ...) pr_debug("[HDCP_TOP]:"__VA_ARGS__)

Hi Bhawanpreet,

Thanks for this patch,
I noticed that some users in the Freedesktop reported issues related to
HDCP due to this WARN message; I think this change will help with that.

Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>

> -- 
> 2.25.1
> 

-- 
Rodrigo Siqueira
https://siqueira.tech
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20200915/d344929c/attachment-0001.sig>


More information about the amd-gfx mailing list