[PATCH] drm/amd/display: Remove set but used 'temp'

[Alex Deucher]

On Tue, Sep 15, 2020 at 11:34 PM Ye Bin <yebin10 at huawei.com> wrote:
>
> Addresses the following gcc warning with "make W=1":
>
> In file included from drivers/gpu/drm/amd/amdgpu/../display/dmub/src/../dmub_srv.h:67:0,
>         from drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_dcn21.c:26:
> drivers/gpu/drm/amd/amdgpu/../display/dmub/src/../inc/dmub_cmd.h: In function ‘dmub_rb_flush_pending’:
> drivers/gpu/drm/amd/amdgpu/../display/dmub/src/../inc/dmub_cmd.h:795:12: warning: variable ‘temp’ set but not used
>  [-Wunused-but-set-variable]
>     uint64_t temp;
>                 ^
> In file included from drivers/gpu/drm/amd/amdgpu/../display/dmub/src/../dmub_srv.h:67:0,
>                  from drivers/gpu/drm/amd/amdgpu/../display/dmub/src/dmub_dcn30.c:26:
> drivers/gpu/drm/amd/amdgpu/../display/dmub/src/../inc/dmub_cmd.h: In function ‘dmub_rb_flush_pending’:
> drivers/gpu/drm/amd/amdgpu/../display/dmub/src/../inc/dmub_cmd.h:795:12: warning: variable ‘temp’ set but not used
> [-Wunused-but-set-variable]
>    uint64_t temp;
>
> Reported-by: Hulk Robot <hulkci at huawei.com>
> Signed-off-by: Ye Bin <yebin10 at huawei.com>

Applied.  Thanks!

Alex

> ---
>  drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
> index d7e7f2eda92f..e32828ffc3e0 100644
> --- a/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
> +++ b/drivers/gpu/drm/amd/display/dmub/inc/dmub_cmd.h
> @@ -791,12 +791,10 @@ static inline void dmub_rb_flush_pending(const struct dmub_rb *rb)
>
>         while (rptr != wptr) {
>                 uint64_t volatile *data = (uint64_t volatile *)rb->base_address + rptr / sizeof(uint64_t);
> -               //uint64_t volatile *p = (uint64_t volatile *)data;
> -               uint64_t temp;
>                 int i;
>
>                 for (i = 0; i < DMUB_RB_CMD_SIZE / sizeof(uint64_t); i++)
> -                       temp = *data++;
> +                       *data++;
>
>                 rptr += DMUB_RB_CMD_SIZE;
>                 if (rptr >= rb->capacity)
> --
> 2.16.2.dirty
>
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx