[PATCH] drm/amdgpu: Add uid info to process BO list

[Chauhan, Madhav]

[AMD Public Use]

-----Original Message-----
From: Christian König <ckoenig.leichtzumerken at gmail.com> 
Sent: Tuesday, September 22, 2020 12:54 AM
To: Chauhan, Madhav <Madhav.Chauhan at amd.com>; amd-gfx at lists.freedesktop.org
Cc: Surampalli, Kishore <Kishore.Surampalli at amd.com>; Patel, Mihir <Mihir.Patel at amd.com>; Sharma, Shashank <Shashank.Sharma at amd.com>; Deucher, Alexander <Alexander.Deucher at amd.com>; Saleem, Athar <Athar.Saleem at amd.com>
Subject: Re: [PATCH] drm/amdgpu: Add uid info to process BO list

Am 21.09.20 um 21:18 schrieb Madhav Chauhan:
> UID is helpful while doing analysis of BO allocated by a process.

Looks like a bit overkill to me, why not get the uid from the process info?

Not sure if I got your point , but used the similar method implemented at drm level inside drm_debugfs.c. Thanks

Regards,
Madhav

Christian.

>
> Signed-off-by: Madhav Chauhan <madhav.chauhan at amd.com>
> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c | 6 +++++-
>   1 file changed, 5 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c 
> b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> index f4c2e2e75b8f..c1982349ec7b 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c
> @@ -892,6 +892,7 @@ static int amdgpu_debugfs_gem_info(struct seq_file *m, void *data)
>   	struct drm_info_node *node = (struct drm_info_node *)m->private;
>   	struct drm_device *dev = node->minor->dev;
>   	struct drm_file *file;
> +	kuid_t uid;
>   	int r;
>   
>   	r = mutex_lock_interruptible(&dev->filelist_mutex);
> @@ -909,7 +910,10 @@ static int amdgpu_debugfs_gem_info(struct seq_file *m, void *data)
>   		 */
>   		rcu_read_lock();
>   		task = pid_task(file->pid, PIDTYPE_PID);
> -		seq_printf(m, "pid %8d command %s:\n", pid_nr(file->pid),
> +		uid = task ? __task_cred(task)->euid : GLOBAL_ROOT_UID;
> +		seq_printf(m, "pid %8d uid %5d command %s:\n",
> +			   pid_nr(file->pid),
> +			   from_kuid_munged(seq_user_ns(m), uid),
>   			   task ? task->comm : "<unknown>");
>   		rcu_read_unlock();
>