[PATCH] drm/amdkfd: fix wanting in print statement

Alex Deucher alexdeucher at gmail.com
Mon Sep 21 21:32:33 UTC 2020


"warning" in print statement.  Fixed locally.

On Mon, Sep 21, 2020 at 5:20 PM Alex Deucher <alexdeucher at gmail.com> wrote:
>
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c: In function ‘kfd_create_crat_image_virtual’:
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:1391:12: warning: format ‘%d’ expects argument of type ‘int’, but argument 3 has type ‘size_t’ {aka ‘long unsigned int’} [-Wformat=]
>  1391 |   pr_debug("CRAT size is %d", dyn_size);
>       |            ^~~~~~~~~~~~~~~~~
> ./include/linux/printk.h:297:21: note: in definition of macro ‘pr_fmt’
>   297 | #define pr_fmt(fmt) fmt
>       |                     ^~~
> ./include/linux/dynamic_debug.h:143:2: note: in expansion of macro ‘__dynamic_func_call’
>   143 |  __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
>       |  ^~~~~~~~~~~~~~~~~~~
> ./include/linux/dynamic_debug.h:153:2: note: in expansion of macro ‘_dynamic_func_call’
>   153 |  _dynamic_func_call(fmt, __dynamic_pr_debug,  \
>       |  ^~~~~~~~~~~~~~~~~~
> ./include/linux/printk.h:420:2: note: in expansion of macro ‘dynamic_pr_debug’
>   420 |  dynamic_pr_debug(fmt, ##__VA_ARGS__)
>       |  ^~~~~~~~~~~~~~~~
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:1391:3: note: in expansion of macro ‘pr_debug’
>  1391 |   pr_debug("CRAT size is %d", dyn_size);
>       |   ^~~~~~~~
> drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:1391:27: note: format string is defined here
>  1391 |   pr_debug("CRAT size is %d", dyn_size);
>       |                          ~^
>       |                           |
>       |                           int
>       |                          %ld
>
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> index c50e9f634d6c..d2981524dba0 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> @@ -1388,7 +1388,7 @@ int kfd_create_crat_image_virtual(void **crat_image, size_t *size,
>                 if (!pcrat_image)
>                         return -ENOMEM;
>                 *size = dyn_size;
> -               pr_debug("CRAT size is %d", dyn_size);
> +               pr_debug("CRAT size is %ld", dyn_size);
>                 ret = kfd_create_vcrat_image_cpu(pcrat_image, size);
>                 break;
>         case COMPUTE_UNIT_GPU:
> --
> 2.25.4
>


More information about the amd-gfx mailing list