[PATCH] drm/amdkfd: fix wanting in print statement

[Alex Deucher]

Can I get an RB?

On Tue, Sep 22, 2020 at 9:56 AM Russell, Kent <Kent.Russell at amd.com> wrote:
>
> [AMD Public Use]
>
> Thanks Alex, sorry about that!
>
>  Kent
>
> > -----Original Message-----
> > From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> On Behalf Of Alex Deucher
> > Sent: Monday, September 21, 2020 5:33 PM
> > To: amd-gfx list <amd-gfx at lists.freedesktop.org>
> > Cc: Deucher, Alexander <Alexander.Deucher at amd.com>
> > Subject: Re: [PATCH] drm/amdkfd: fix wanting in print statement
> >
> > "warning" in print statement.  Fixed locally.
> >
> > On Mon, Sep 21, 2020 at 5:20 PM Alex Deucher <alexdeucher at gmail.com> wrote:
> > >
> > > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c: In function
> > ‘kfd_create_crat_image_virtual’:
> > > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:1391:12: warning: format ‘%d’
> > expects argument of type ‘int’, but argument 3 has type ‘size_t’ {aka ‘long unsigned int’} [-
> > Wformat=]
> > >  1391 |   pr_debug("CRAT size is %d", dyn_size);
> > >       |            ^~~~~~~~~~~~~~~~~
> > > ./include/linux/printk.h:297:21: note: in definition of macro ‘pr_fmt’
> > >   297 | #define pr_fmt(fmt) fmt
> > >       |                     ^~~
> > > ./include/linux/dynamic_debug.h:143:2: note: in expansion of macro
> > ‘__dynamic_func_call’
> > >   143 |  __dynamic_func_call(__UNIQUE_ID(ddebug), fmt, func, ##__VA_ARGS__)
> > >       |  ^~~~~~~~~~~~~~~~~~~
> > > ./include/linux/dynamic_debug.h:153:2: note: in expansion of macro
> > ‘_dynamic_func_call’
> > >   153 |  _dynamic_func_call(fmt, __dynamic_pr_debug,  \
> > >       |  ^~~~~~~~~~~~~~~~~~
> > > ./include/linux/printk.h:420:2: note: in expansion of macro ‘dynamic_pr_debug’
> > >   420 |  dynamic_pr_debug(fmt, ##__VA_ARGS__)
> > >       |  ^~~~~~~~~~~~~~~~
> > > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:1391:3: note: in expansion of macro
> > ‘pr_debug’
> > >  1391 |   pr_debug("CRAT size is %d", dyn_size);
> > >       |   ^~~~~~~~
> > > drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_crat.c:1391:27: note: format string is
> > defined here
> > >  1391 |   pr_debug("CRAT size is %d", dyn_size);
> > >       |                          ~^
> > >       |                           |
> > >       |                           int
> > >       |                          %ld
> > >
> > > Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> > > ---
> > >  drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> > b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> > > index c50e9f634d6c..d2981524dba0 100644
> > > --- a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> > > +++ b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c
> > > @@ -1388,7 +1388,7 @@ int kfd_create_crat_image_virtual(void **crat_image, size_t
> > *size,
> > >                 if (!pcrat_image)
> > >                         return -ENOMEM;
> > >                 *size = dyn_size;
> > > -               pr_debug("CRAT size is %d", dyn_size);
> > > +               pr_debug("CRAT size is %ld", dyn_size);
> > >                 ret = kfd_create_vcrat_image_cpu(pcrat_image, size);
> > >                 break;
> > >         case COMPUTE_UNIT_GPU:
> > > --
> > > 2.25.4
> > >
> > _______________________________________________
> > amd-gfx mailing list
> > amd-gfx at lists.freedesktop.org
> > https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.or
> > g%2Fmailman%2Flistinfo%2Famd-
> > gfx&data=02%7C01%7Ckent.russell%40amd.com%7C611fc25735e041fbd3d708d85e75
> > e355%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637363207721737766&
> > sdata=BvMRCPYK0WuXTJAotNMFfG7lBn2t4dYogDUoRZQrTdA%3D&reserved=0