[PATCH 01/11] drm/ttm: add ttm_bo_pin()/ttm_bo_unpin() v2

Daniel Vetter daniel at ffwll.ch
Thu Sep 24 09:00:59 UTC 2020


On Wed, Sep 23, 2020 at 01:01:14PM +1000, Dave Airlie wrote:
> On Tue, 22 Sep 2020 at 23:32, Christian König
> <ckoenig.leichtzumerken at gmail.com> wrote:
> >
> > As an alternative to the placement flag add a
> > pin count to the ttm buffer object.
> 
> These all look good to me, nice cleanup.
> 
> For the series:
> Reviewed-by: Dave Airlie <airlied at redhat.com>

Yeah I like, but plenty of review already so I wont bother.

I do wonder whether we should/could lift this one more level to
drm_gem_object, since cma/shmem gem helpers have this too.

But they have hand-rolled locking for it of dubious quality, and don't use
dma_resv_lock for any of this unfortunately. And I guess that would need
to be fixed first.
-Daniel
-- 
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch


More information about the amd-gfx mailing list