[PATCH] drm/amdgpu: fix a warning in amdgpu_ras.c (v2)

[Luben Tuikov]

Reviewed-by: Luben Tuikov <luben.tuikov at amd.com>

That's what I had in mind. No error--let the system survive as much as it can.

Regards,
Luben

On 2020-09-25 15:23, Alex Deucher wrote:
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c: In function ‘amdgpu_ras_fs_init’:
> drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c:1284:2: warning: ignoring return value of ‘sysfs_create_group’, declared with attribute warn_unused_result [-Wunused-result]
>  1284 |  sysfs_create_group(&adev->dev->kobj, &group);
>       |  ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> v2: just print an error for sysfs group creation failure
> 
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> index 49d10330bf64..8bf6a7c056bc 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_ras.c
> @@ -1266,6 +1266,7 @@ static int amdgpu_ras_fs_init(struct amdgpu_device *adev)
>  		NULL,
>  		NULL,
>  	};
> +	int r;
>  
>  	/* add features entry */
>  	con->features_attr = dev_attr_features;
> @@ -1281,7 +1282,9 @@ static int amdgpu_ras_fs_init(struct amdgpu_device *adev)
>  		sysfs_bin_attr_init(bin_attrs[0]);
>  	}
>  
> -	sysfs_create_group(&adev->dev->kobj, &group);
> +	r = sysfs_create_group(&adev->dev->kobj, &group);
> +	if (r)
> +		dev_err(adev->dev, "Failed to create RAS sysfs group!");
>  
>  	return 0;
>  }
>