[PATCH] drm/amd/display: remove duplicate call to rn_vbios_smu_get_smu_version()

[Alex Deucher]

Applied.  Thanks!

Alex

On Mon, Sep 28, 2020 at 3:07 AM Dirk Gouders <dirk at gouders.net> wrote:
>
> Commit 78fe9f63947a2b (drm/amd/display: Remove DISPCLK Limit Floor
> for Certain SMU Versions) added a call to
> rn_vbios_smu_get_smu_version() to set clk_mgr->smu_ver.  That field is
> initialized prior to the if-statement, already.
>
> Fixes: 78fe9f63947a2b (drm/amd/display: Remove DISPCLK Limit Floor for Certain SMU Versions)
> Signed-off-by: Dirk Gouders <dirk at gouders.net>
> Cc: Alex Deucher <alexander.deucher at amd.com>
> Cc: Sung Lee <sung.lee at amd.com>
> Cc: Yongqiang Sun <yongqiang.sun at amd.com>
> Cc: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> ---
>  drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c
> index 543afa34d87a..21a3073c8929 100644
> --- a/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c
> +++ b/drivers/gpu/drm/amd/display/dc/clk_mgr/dcn21/rn_clk_mgr.c
> @@ -783,7 +783,6 @@ void rn_clk_mgr_construct(
>         } else {
>                 struct clk_log_info log_info = {0};
>
> -               clk_mgr->smu_ver = rn_vbios_smu_get_smu_version(clk_mgr);
>                 clk_mgr->periodic_retraining_disabled = rn_vbios_smu_is_periodic_retraining_disabled(clk_mgr);
>
>                 /* SMU Version 55.51.0 and up no longer have an issue
> --
> 2.26.2
> _______________________________________________
> amd-gfx mailing list
> amd-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/amd-gfx