[PATCH 8/9] drm/ttm: Don't count pages in SG BOs against pages_limit

Felix Kuehling felix.kuehling at amd.com
Wed Apr 14 14:41:59 UTC 2021


Am 2021-04-14 um 8:25 a.m. schrieb Daniel Vetter:
>> Sorry I though that this would be obvious :)
>>
>> I've already pushed the patch in the morning, but going to keep that in
>> mind for the next time.
> I'll keep reminding you to pls elaborate more in commit messages, it's
> coming up every once in a while :-)

It was actually my patch and commit message. I was not aware of the
history of this bug or the fact that it was a regression. Otherwise I
would have included a "Fixes:" tag. From my point of view it was just a
pretty obvious problem exposed when testing my DMA mapping patch series
for KFD.

Regards,
  Felix


>
> Also in general I think a few days of letting patches soak out there,
> especially shared code, is good curtesy. Some folks demand 2 weeks,
> which I think is too much, but less than 24h just means you're
> guaranteed to leave out half the globe with their feedback. Which
> isn't great.
>
> Driver code I don't care since there you know all the stakeholders ofc.
> -Daniel
>


More information about the amd-gfx mailing list