[PATCH] Handling of amdgpu_device_resume return value for graceful teardown

[Alex Deucher]

Applied.  Thanks!

Alex

On Tue, Apr 27, 2021 at 1:46 PM Alex Deucher <alexdeucher at gmail.com> wrote:
>
> On Tue, Apr 27, 2021 at 12:51 AM <pavan.ramayanam at amd.com> wrote:
> >
> > From: Pavan Kumar Ramayanam <pavan.ramayanam at amd.com>
> >
> > The runtime resume PM op disregards the return value from
> > amdgpu_device_resume(), masking errors for failed resumes at the PM
> > layer.
> >
> > Signed-off-by: Pavan Kumar Ramayanam <pavan.ramayanam at amd.com>
>
> Subject should be prefixed with drm/amdgpu:, with that fixed,
> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
>
> Do you need me to commit this for you?
>
> Alex
>
>
> > ---
> >  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 3 +++
> >  1 file changed, 3 insertions(+)
> >
> > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> > index 0369d3532bf0..03f3cf194300 100644
> > --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> > +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
> > @@ -1574,6 +1574,9 @@ static int amdgpu_pmops_runtime_resume(struct device *dev)
> >                 amdgpu_device_baco_exit(drm_dev);
> >         }
> >         ret = amdgpu_device_resume(drm_dev, false);
> > +       if (ret)
> > +               return ret;
> > +
> >         if (amdgpu_device_supports_px(drm_dev))
> >                 drm_dev->switch_power_state = DRM_SWITCH_POWER_ON;
> >         adev->in_runpm = false;
> > --
> > 2.17.1
> >
> > _______________________________________________
> > amd-gfx mailing list
> > amd-gfx at lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/amd-gfx