Re:Re: [PATCH] drm/amd/display: Remove duplicate include of hubp.h

Jiabing Wan wanjiabing at vivo.com
Thu Apr 29 12:23:15 UTC 2021


 
>Nice catch!
>
>Are you using any tool to identify this problem?

Yes, I have a robot including many detecting scripts :)

>Reviewed-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
>
>On 04/29, Wan Jiabing wrote:
>> In commit 482812d56698e ("drm/amd/display: Set max TTU on
>> DPG enable"), "hubp.h" was added which caused the duplicate include.
>> To be on the safe side, remove the later duplicate include.
>> 
>> Signed-off-by: Wan Jiabing <wanjiabing at vivo.com>
>> ---
>>  drivers/gpu/drm/amd/display/dc/core/dc.c | 1 -
>>  1 file changed, 1 deletion(-)
>> 
>> diff --git a/drivers/gpu/drm/amd/display/dc/core/dc.c b/drivers/gpu/drm/amd/display/dc/core/dc.c
>> index 8f0a13807d05..dcaa6b1e16af 100644
>> --- a/drivers/gpu/drm/amd/display/dc/core/dc.c
>> +++ b/drivers/gpu/drm/amd/display/dc/core/dc.c
>> @@ -58,7 +58,6 @@
>>  #include "dc_link_ddc.h"
>>  #include "dm_helpers.h"
>>  #include "mem_input.h"
>> -#include "hubp.h"
>>  
>>  #include "dc_link_dp.h"
>>  #include "dc_dmub_srv.h"
>> -- 
>> 2.25.1
>> 
>
>-- 
>Rodrigo Siqueira
>https://siqueira.tech

Yours,
Wan Jiabing



More information about the amd-gfx mailing list