[PATCH 1/1] drm/amdgpu: remove excess function parameter

[Nirmoy]

On 4/30/21 2:56 PM, Christian König wrote:
> Hi,
>
> Am 30.04.21 um 14:52 schrieb Rodrigo Siqueira:
>> Hi,
>>
>> On 04/30, Nirmoy Das wrote:
>>> Fixes: 49020fc1f5("drm/amdgpu: cleanup amdgpu_vm_init()")
>> Just for curiosity, do we need the Fixes tag for this?
>
> It's indeed a bit overkill.
>
> The purpose of the Fixes tag is to mark bug fixes for specific patches 
> so that backporters of feature know that when they picked up patch A 
> they also need to pick up the fixes for patch A.
>
> But since this is just cleaning up a recently added warning in a code 
> documentation we could just push it without.


Thanks Rodrigo and Christian, I will resend again without Fixes tag.


Nirmoy


>
> Christian.
>
>> How about adding the warning/error message that this patch fixes? I
>> think this can be useful for other people searching for a similar fix in
>> the git log (I do it sometimes).
>>
>> Thanks
>> Siqueira
>>   
>>> Signed-off-by: Nirmoy Das<nirmoy.das at amd.com>
>>> ---
>>>   drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 1 -
>>>   1 file changed, 1 deletion(-)
>>>
>>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>>> index dae51992c607..f2513be72980 100644
>>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
>>> @@ -2796,7 +2796,6 @@ long amdgpu_vm_wait_idle(struct amdgpu_vm *vm, long timeout)
>>>    *
>>>    * @adev: amdgpu_device pointer
>>>    * @vm: requested vm
>>> - * @vm_context: Indicates if it GFX or Compute context
>>>    * @pasid: Process address space identifier
>>>    *
>>>    * Init @vm fields.
>>> -- 
>>> 2.30.2
>>>
>>> _______________________________________________
>>> amd-gfx mailing list
>>> amd-gfx at lists.freedesktop.org
>>> https://nam11.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.freedesktop.org%2Fmailman%2Flistinfo%2Famd-gfx&data=04%7C01%7CRodrigo.Siqueira%40amd.com%7Ca88acdf110bc4994ff3c08d90bcd36f6%7C3dd8961fe4884e608e11a82d994e183d%7C0%7C0%7C637553798286590199%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=tS6NA4FPNYFPCbIdngKshN3I%2BwRwAumgC0vdA50h9l8%3D&reserved=0
>>
>> _______________________________________________
>> amd-gfx mailing list
>> amd-gfx at lists.freedesktop.org
>> https://lists.freedesktop.org/mailman/listinfo/amd-gfx
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20210430/06bd8a2b/attachment.htm>