[PATCH 1/1] drm/amdgpu: Add a new device ID for Aldebaran

[Luo, Zhigang]

[AMD Official Use Only - Internal Distribution Only]

Thanks, Felix. The change looks good for me.

--Zhigang

-----Original Message-----
From: Kuehling, Felix <Felix.Kuehling at amd.com>
Sent: April 30, 2021 1:45 PM
To: Luo, Zhigang <Zhigang.Luo at amd.com>; amd-gfx at lists.freedesktop.org
Subject: Re: [PATCH 1/1] drm/amdgpu: Add a new device ID for Aldebaran

It just took me two minutes to do this myself. The commit is up for review on Gerrit:
http://gerrit-git.amd.com/c/compute/ec/libhsakmt/+/518573. Please review and test this.

Regards,
  Felix


Am 2021-04-29 um 2:46 p.m. schrieb Luo, Zhigang:
> [AMD Official Use Only - Internal Distribution Only]
>
> Thanks, Felix.
> Yes, I will sent out several patches for Aldebaran virtualization support soon.
>
> Thanks,
> Zhigang
>
> -----Original Message-----
> From: Kuehling, Felix <Felix.Kuehling at amd.com>
> Sent: April 29, 2021 2:40 PM
> To: Luo, Zhigang <Zhigang.Luo at amd.com>; amd-gfx at lists.freedesktop.org
> Subject: Re: [PATCH 1/1] drm/amdgpu: Add a new device ID for Aldebaran
>
> Am 2021-04-29 um 2:33 p.m. schrieb Zhigang Luo:
>> It is Aldebaran VF device ID, for virtualization support.
>>
>> Signed-off-by: Zhigang Luo <zhigang.luo at amd.com>
> This patch looks good to me.
>
> Acked-by: Felix Kuehling <Felix.Kuehling at amd.com>
>
> I believe you'll also need to add an entry for the VF in kfd_supported_devices in kfd_device.c.
>
> Regards,
>   Felix
>
>
>> ---
>>  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> index 0369d3532bf0..310e1249e64e 100644
>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c
>> @@ -1186,6 +1186,7 @@ static const struct pci_device_id pciidlist[] =
>> {  {0x1002, 0x7408, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
>> CHIP_ALDEBARAN|AMD_EXP_HW_SUPPORT},
>>  {0x1002, 0x740C, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
>> CHIP_ALDEBARAN|AMD_EXP_HW_SUPPORT},
>>  {0x1002, 0x740F, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
>> CHIP_ALDEBARAN|AMD_EXP_HW_SUPPORT},
>> +{0x1002, 0x7410, PCI_ANY_ID, PCI_ANY_ID, 0, 0,
>> +CHIP_ALDEBARAN|AMD_EXP_HW_SUPPORT},
>>
>>  {0, 0, 0}
>>  };