[PATCH v8] drm/amdgpu: handle IH ring1 overflow
Mike Lothian
mike at fireburn.co.uk
Thu Dec 2 12:43:41 UTC 2021
On Thu, 25 Nov 2021 at 20:42, Felix Kuehling <felix.kuehling at amd.com> wrote:
>
> OK. Dealing with processed timestamp rather than decoded timestamp fixes
> the race condition where drain would have returned before the last fault
> was processed. But we're still assuming that each interrupt has a unique
> timestamp. We haven't seen evidence of the contrary. But I'd like to add
> a check to be sure, in case that assumption becomes invalid on future
> hardware. Something like this (before updating ih->processed_timestamp):
>
> WARN_ONCE(ih->processed_timestamp == entry.timestamp, "IH timestamps
> are not unique");
>
> With that fixed, the patch is
>
> Reviewed-by: Felix Kuehling <Felix.Kuehling at amd.com>
>
Hi,
I'm seeing this on my machine
https://gitlab.freedesktop.org/drm/amd/-/issues/1818
Cheers
Mike
More information about the amd-gfx
mailing list