[PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed

Quan, Evan Evan.Quan at amd.com
Mon Dec 6 01:43:43 UTC 2021


[AMD Official Use Only]

Hi Stanley,

There is already error prompts in the smu_cmn_send_smc_msg_with_param() used by the API mentioned below.
Can that cover your use case?

BR
Evan
> -----Original Message-----
> From: Stanley.Yang <Stanley.Yang at amd.com>
> Sent: Sunday, December 5, 2021 6:02 PM
> To: amd-gfx at lists.freedesktop.org; Zhang, Hawking
> <Hawking.Zhang at amd.com>; Clements, John <John.Clements at amd.com>;
> Zhou1, Tao <Tao.Zhou1 at amd.com>; Li, Candice <Candice.Li at amd.com>;
> Chai, Thomas <YiPeng.Chai at amd.com>; Quan, Evan <Evan.Quan at amd.com>
> Cc: Yang, Stanley <Stanley.Yang at amd.com>
> Subject: [PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed
> 
> Signed-off-by: Stanley.Yang <Stanley.Yang at amd.com>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> index 6e781cee8bb6..e0a8224e466f 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> @@ -1815,7 +1815,7 @@ static ssize_t aldebaran_get_ecc_info(struct
> smu_context *smu,
>  			       smu_table->ecc_table,
>  			       false);
>  	if (ret) {
> -		dev_info(smu->adev->dev, "Failed to export SMU ecc
> table!\n");
> +		dev_info(smu->adev->dev, "Failed to export SMU ecc table!
> ret %d.\n", ret);
>  		return ret;
>  	}
> 
> --
> 2.17.1


More information about the amd-gfx mailing list