[PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed

[Quan, Evan]

[AMD Official Use Only]

OK. If that can help the debugging for RAS development, I’m fine with it.
Reviewed-by: Evan Quan <evan.quan at amd.com>

BR
Evan
From: Yang, Stanley <Stanley.Yang at amd.com>
Sent: Monday, December 6, 2021 8:37 PM
To: Quan, Evan <Evan.Quan at amd.com>; amd-gfx at lists.freedesktop.org; Zhang, Hawking <Hawking.Zhang at amd.com>; Clements, John <John.Clements at amd.com>; Zhou1, Tao <Tao.Zhou1 at amd.com>; Li, Candice <Candice.Li at amd.com>; Chai, Thomas <YiPeng.Chai at amd.com>
Subject: 答复: [PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed

Hi Evan,

The error prompts in function smu_cmn_send_smc_msg_with_param do not cover all failed cases since it only prints reg stat SMU_RESP_NONE,
SMU_RESP_BUSY_OTHER or response -EREMOTEIO. I think it is better update reg error stat judgment conditions to print more error msg.

Regards,
Stanley
发件人: Quan, Evan <Evan.Quan at amd.com<mailto:Evan.Quan at amd.com>>
日期: 星期一, 2021年12月6日 上午9:43
收件人: Yang, Stanley <Stanley.Yang at amd.com<mailto:Stanley.Yang at amd.com>>, amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org> <amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>>, Zhang, Hawking <Hawking.Zhang at amd.com<mailto:Hawking.Zhang at amd.com>>, Clements, John <John.Clements at amd.com<mailto:John.Clements at amd.com>>, Zhou1, Tao <Tao.Zhou1 at amd.com<mailto:Tao.Zhou1 at amd.com>>, Li, Candice <Candice.Li at amd.com<mailto:Candice.Li at amd.com>>, Chai, Thomas <YiPeng.Chai at amd.com<mailto:YiPeng.Chai at amd.com>>
抄送: Yang, Stanley <Stanley.Yang at amd.com<mailto:Stanley.Yang at amd.com>>
主题: RE: [PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed
[AMD Official Use Only]

Hi Stanley,

There is already error prompts in the smu_cmn_send_smc_msg_with_param() used by the API mentioned below.
Can that cover your use case?

BR
Evan
> -----Original Message-----
> From: Stanley.Yang <Stanley.Yang at amd.com<mailto:Stanley.Yang at amd.com>>
> Sent: Sunday, December 5, 2021 6:02 PM
> To: amd-gfx at lists.freedesktop.org<mailto:amd-gfx at lists.freedesktop.org>; Zhang, Hawking
> <Hawking.Zhang at amd.com<mailto:Hawking.Zhang at amd.com>>; Clements, John <John.Clements at amd.com<mailto:John.Clements at amd.com>>;
> Zhou1, Tao <Tao.Zhou1 at amd.com<mailto:Tao.Zhou1 at amd.com>>; Li, Candice <Candice.Li at amd.com<mailto:Candice.Li at amd.com>>;
> Chai, Thomas <YiPeng.Chai at amd.com<mailto:YiPeng.Chai at amd.com>>; Quan, Evan <Evan.Quan at amd.com<mailto:Evan.Quan at amd.com>>
> Cc: Yang, Stanley <Stanley.Yang at amd.com<mailto:Stanley.Yang at amd.com>>
> Subject: [PATCH Review 1/1] drm/amd/pm: print errorno if get ecc info failed
>
> Signed-off-by: Stanley.Yang <Stanley.Yang at amd.com<mailto:Stanley.Yang at amd.com>>
> ---
>  drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> index 6e781cee8bb6..e0a8224e466f 100644
> --- a/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> +++ b/drivers/gpu/drm/amd/pm/swsmu/smu13/aldebaran_ppt.c
> @@ -1815,7 +1815,7 @@ static ssize_t aldebaran_get_ecc_info(struct
> smu_context *smu,
>                               smu_table->ecc_table,
>                               false);
>        if (ret) {
> -             dev_info(smu->adev->dev, "Failed to export SMU ecc
> table!\n");
> +             dev_info(smu->adev->dev, "Failed to export SMU ecc table!
> ret %d.\n", ret);
>                return ret;
>        }
>
> --
> 2.17.1
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20211207/5dc6ce9d/attachment-0001.htm>