[PATCH 1/2] drm/amdgpu: remove power on/off SDMA in SMU hw_init/fini()

[Wang, Yang(Kevin)]

[AMD Official Use Only]

Hi Lang,

the function of smu_powergate_sdma() is only valid on renoir chip.
if you want to remove it, please also remove following callback pointer in struct pptable_funcs{}.
related macro definitions also need to be cleaned up.

int (*powergate_sdma)(struct smu_context *smu, bool gate);

Best Regards,
Kevin
________________________________
From: amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of Lang Yu <lang.yu at amd.com>
Sent: Wednesday, December 8, 2021 5:26 PM
To: amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
Cc: Deucher, Alexander <Alexander.Deucher at amd.com>; Yu, Lang <Lang.Yu at amd.com>; Lazar, Lijo <Lijo.Lazar at amd.com>; Huang, Ray <Ray.Huang at amd.com>
Subject: [PATCH 1/2] drm/amdgpu: remove power on/off SDMA in SMU hw_init/fini()

Currently, we don't find some neccesities to power on/off
SDMA in SMU hw_init/fini(). It makes more sense in SDMA
hw_init/fini().

Signed-off-by: Lang Yu <lang.yu at amd.com>
---
 drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 5 -----
 1 file changed, 5 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
index 5839918cb574..2d718c30c8eb 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
@@ -1350,7 +1350,6 @@ static int smu_hw_init(void *handle)
         }

         if (smu->is_apu) {
-               smu_powergate_sdma(&adev->smu, false);
                 smu_dpm_set_vcn_enable(smu, true);
                 smu_dpm_set_jpeg_enable(smu, true);
                 smu_set_gfx_cgpg(&adev->smu, true);
@@ -1512,10 +1511,6 @@ static int smu_hw_fini(void *handle)
         if (amdgpu_sriov_vf(adev)&& !amdgpu_sriov_is_pp_one_vf(adev))
                 return 0;

-       if (smu->is_apu) {
-               smu_powergate_sdma(&adev->smu, true);
-       }
-
         smu_dpm_set_vcn_enable(smu, false);
         smu_dpm_set_jpeg_enable(smu, false);

--
2.25.1

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20211208/87c44274/attachment-0001.htm>