[PATCH 04/10] drm/amdgpu: fix function scopes

Alex Deucher alexdeucher at gmail.com
Wed Dec 8 19:44:23 UTC 2021


Applied with minor tweaks to the commit message.  Thanks!

Alex

On Tue, Dec 7, 2021 at 10:17 PM Isabella Basso <isabbasso at riseup.net> wrote:
>
> This turns previously global functions into static, thus removing
> compile-time warnings such as:
>
>  warning: no previous prototype for 'release_psp_cmd_buf' [-Wmissing-prototypes]
>  521 | void release_psp_cmd_buf(struct psp_context *psp)
>      |      ^~~~~~~~~~~~~~~~~~~
>  ...
>  warning: no previous prototype for 'amdgpu_vkms_output_init' [-Wmissing-prototypes]
>  399 | int amdgpu_vkms_output_init(struct drm_device *dev,
>      |     ^~~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Isabella Basso <isabbasso at riseup.net>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c
> index af3a2f8c12b4..96895cccf9e7 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vkms.c
> @@ -411,8 +411,8 @@ static struct drm_plane *amdgpu_vkms_plane_init(struct drm_device *dev,
>         return plane;
>  }
>
> -int amdgpu_vkms_output_init(struct drm_device *dev,
> -                           struct amdgpu_vkms_output *output, int index)
> +static int amdgpu_vkms_output_init(struct drm_device *dev, struct
> +                                  amdgpu_vkms_output *output, int index)
>  {
>         struct drm_connector *connector = &output->connector;
>         struct drm_encoder *encoder = &output->encoder;
> --
> 2.34.1
>


More information about the amd-gfx mailing list