[PATCH 08/10] drm/amdgpu: fix location of prototype for amdgpu_kms_compat_ioctl

Alex Deucher alexdeucher at gmail.com
Wed Dec 8 19:50:12 UTC 2021


Applied.  Thanks!

On Tue, Dec 7, 2021 at 10:17 PM Isabella Basso <isabbasso at riseup.net> wrote:
>
> This fixes the warning below by changing the prototype to a location
> that's actually included by the .c files that call
> amdgpu_kms_compat_ioctl:
>
>  warning: no previous prototype for ‘amdgpu_kms_compat_ioctl’
>  [-Wmissing-prototypes]
>  37 | long amdgpu_kms_compat_ioctl(struct file *filp, unsigned int cmd, unsigned long arg)
>     |      ^~~~~~~~~~~~~~~~~~~~~~~
>
> Signed-off-by: Isabella Basso <isabbasso at riseup.net>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu.h     | 2 --
>  drivers/gpu/drm/amd/amdgpu/amdgpu_drv.h | 3 +++
>  2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu.h b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> index c5cfe2926ca1..54c882a6b433 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu.h
> @@ -1360,8 +1360,6 @@ int amdgpu_device_resume(struct drm_device *dev, bool fbcon);
>  u32 amdgpu_get_vblank_counter_kms(struct drm_crtc *crtc);
>  int amdgpu_enable_vblank_kms(struct drm_crtc *crtc);
>  void amdgpu_disable_vblank_kms(struct drm_crtc *crtc);
> -long amdgpu_kms_compat_ioctl(struct file *filp, unsigned int cmd,
> -                            unsigned long arg);
>  int amdgpu_info_ioctl(struct drm_device *dev, void *data,
>                       struct drm_file *filp);
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.h b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.h
> index e3a4f7048042..8178323e4bef 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.h
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.h
> @@ -45,4 +45,7 @@
>  long amdgpu_drm_ioctl(struct file *filp,
>                       unsigned int cmd, unsigned long arg);
>
> +long amdgpu_kms_compat_ioctl(struct file *filp,
> +                            unsigned int cmd, unsigned long arg);
> +
>  #endif
> --
> 2.34.1
>


More information about the amd-gfx mailing list