[PATCH 2/2] drm/amd: move variable to local scope

Harry Wentland harry.wentland at amd.com
Fri Dec 10 16:24:35 UTC 2021


With Christian's comments addressed both patches are
Reviewed-by: Harry Wentland <harry.wentland at amd.com>

Harry

On 2021-12-10 10:54, Mario Limonciello wrote:
> `edp_stream` is only used when backend is enabled on eDP, don't
> declare the variable outside that scope.
> 
> Signed-off-by: Mario Limonciello <mario.limonciello at amd.com>
> ---
>  drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> index 0d6dc329dddb..fb578b311b98 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce110/dce110_hw_sequencer.c
> @@ -1798,7 +1798,6 @@ void dce110_enable_accelerated_mode(struct dc *dc, struct dc_state *context)
>  	struct dc_stream_state *edp_streams[MAX_NUM_EDP];
>  	struct dc_link *edp_link_with_sink = NULL;
>  	struct dc_link *edp_link = NULL;
> -	struct dc_stream_state *edp_stream = NULL;
>  	struct dce_hwseq *hws = dc->hwseq;
>  	int edp_with_sink_num;
>  	int edp_num;
> @@ -1830,7 +1829,7 @@ void dce110_enable_accelerated_mode(struct dc *dc, struct dc_state *context)
>  			if (edp_link->link_enc->funcs->is_dig_enabled &&
>  			    edp_link->link_enc->funcs->is_dig_enabled(edp_link->link_enc) &&
>  			    edp_link->link_status.link_active) {
> -				edp_stream = edp_streams[0];
> +				struct dc_stream_state *edp_stream = edp_streams[0];
>  				can_apply_edp_fast_boot = !is_edp_ilr_optimization_required(edp_stream->link, &edp_stream->timing);
>  				edp_stream->apply_edp_fast_boot_optimization = can_apply_edp_fast_boot;
>  				if (can_apply_edp_fast_boot)
> 



More information about the amd-gfx mailing list