[PATCH 10/19] drm/amd/display: Changed pipe split policy to allow for multi-display pipe split
Rodrigo Siqueira Jordao
rjordrigo at amd.com
Fri Dec 17 21:51:26 UTC 2021
On 2021-12-17 4:36 p.m., Deucher, Alexander wrote:
> [AMD Official Use Only]
>
>
> Maybe add Bug links for:
> https://gitlab.freedesktop.org/drm/amd/-/issues/1522
> <https://gitlab.freedesktop.org/drm/amd/-/issues/1522>
> https://gitlab.freedesktop.org/drm/amd/-/issues/1709
> <https://gitlab.freedesktop.org/drm/amd/-/issues/1709>
> https://gitlab.freedesktop.org/drm/amd/-/issues/1655
> <https://gitlab.freedesktop.org/drm/amd/-/issues/1655>
> https://gitlab.freedesktop.org/drm/amd/-/issues/1403
> <https://gitlab.freedesktop.org/drm/amd/-/issues/1403>
Sure, I'll update the commit message before apply this patch.
Thanks.
>
>
>
> ------------------------------------------------------------------------
> *From:* amd-gfx <amd-gfx-bounces at lists.freedesktop.org> on behalf of
> Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> *Sent:* Friday, December 17, 2021 4:23 PM
> *To:* amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
> *Cc:* Wang, Chao-kai (Stylon) <Stylon.Wang at amd.com>; Cyr, Aric
> <Aric.Cyr at amd.com>; Li, Sun peng (Leo) <Sunpeng.Li at amd.com>; Wentland,
> Harry <Harry.Wentland at amd.com>; Zhuo, Qingqing (Lillian)
> <Qingqing.Zhuo at amd.com>; Siqueira, Rodrigo <Rodrigo.Siqueira at amd.com>;
> Li, Roman <Roman.Li at amd.com>; Chiu, Solomon <Solomon.Chiu at amd.com>;
> Pillai, Aurabindo <Aurabindo.Pillai at amd.com>; Wang, Angus
> <Angus.Wang at amd.com>; Lin, Wayne <Wayne.Lin at amd.com>; Lipski, Mikita
> <Mikita.Lipski at amd.com>; Lakha, Bhawanpreet <Bhawanpreet.Lakha at amd.com>;
> Gutierrez, Agustin <Agustin.Gutierrez at amd.com>; Kotarac, Pavle
> <Pavle.Kotarac at amd.com>
> *Subject:* [PATCH 10/19] drm/amd/display: Changed pipe split policy to
> allow for multi-display pipe split
> From: Angus Wang <angus.wang at amd.com>
>
> [WHY]
> Current implementation of pipe split policy prevents pipe split with
> multiple displays connected, which caused the MCLK speed to be stuck at
> max
>
> [HOW]
> Changed the pipe split policies so that pipe split is allowed for
> multi-display configurations
>
> Reviewed-by: Aric Cyr <Aric.Cyr at amd.com>
> Acked-by: Rodrigo Siqueira <Rodrigo.Siqueira at amd.com>
> Signed-off-by: Angus Wang <angus.wang at amd.com>
> ---
> drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c | 2 +-
> drivers/gpu/drm/amd/display/dc/dcn201/dcn201_resource.c | 2 +-
> drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c | 2 +-
> drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c | 2 +-
> drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c | 2 +-
> drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c | 2 +-
> drivers/gpu/drm/amd/display/dc/dcn303/dcn303_resource.c | 2 +-
> drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c | 2 +-
> 8 files changed, 8 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c
> b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c
> index 2a72517e2b28..2bc93df023ad 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn20/dcn20_resource.c
> @@ -1069,7 +1069,7 @@ static const struct dc_debug_options
> debug_defaults_drv = {
> .timing_trace = false,
> .clock_trace = true,
> .disable_pplib_clock_request = true,
> - .pipe_split_policy = MPC_SPLIT_AVOID_MULT_DISP,
> + .pipe_split_policy = MPC_SPLIT_DYNAMIC,
> .force_single_disp_pipe_split = false,
> .disable_dcc = DCC_ENABLE,
> .vsr_support = true,
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_resource.c
> b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_resource.c
> index d6acf9a8590a..0bb7d3dd53fa 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn201/dcn201_resource.c
> @@ -603,7 +603,7 @@ static const struct dc_debug_options
> debug_defaults_drv = {
> .timing_trace = false,
> .clock_trace = true,
> .disable_pplib_clock_request = true,
> - .pipe_split_policy = MPC_SPLIT_AVOID,
> + .pipe_split_policy = MPC_SPLIT_DYNAMIC,
> .force_single_disp_pipe_split = false,
> .disable_dcc = DCC_ENABLE,
> .vsr_support = true,
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> index ca1bbc942fd4..e5cc6bf45743 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn21/dcn21_resource.c
> @@ -873,7 +873,7 @@ static const struct dc_debug_options
> debug_defaults_drv = {
> .clock_trace = true,
> .disable_pplib_clock_request = true,
> .min_disp_clk_khz = 100000,
> - .pipe_split_policy = MPC_SPLIT_AVOID_MULT_DISP,
> + .pipe_split_policy = MPC_SPLIT_DYNAMIC,
> .force_single_disp_pipe_split = false,
> .disable_dcc = DCC_ENABLE,
> .vsr_support = true,
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c
> b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c
> index 369ceeeddc7e..e12660c609ee 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn30/dcn30_resource.c
> @@ -840,7 +840,7 @@ static const struct dc_debug_options
> debug_defaults_drv = {
> .timing_trace = false,
> .clock_trace = true,
> .disable_pplib_clock_request = true,
> - .pipe_split_policy = MPC_SPLIT_AVOID_MULT_DISP,
> + .pipe_split_policy = MPC_SPLIT_DYNAMIC,
> .force_single_disp_pipe_split = false,
> .disable_dcc = DCC_ENABLE,
> .vsr_support = true,
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c
> b/drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c
> index b4001233867c..c1c6e602b06c 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn301/dcn301_resource.c
> @@ -686,7 +686,7 @@ static const struct dc_debug_options
> debug_defaults_drv = {
> .disable_clock_gate = true,
> .disable_pplib_clock_request = true,
> .disable_pplib_wm_range = true,
> - .pipe_split_policy = MPC_SPLIT_AVOID,
> + .pipe_split_policy = MPC_SPLIT_DYNAMIC,
> .force_single_disp_pipe_split = false,
> .disable_dcc = DCC_ENABLE,
> .vsr_support = true,
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
> b/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
> index 003e95368672..2e9cbfa7663b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn302/dcn302_resource.c
> @@ -211,7 +211,7 @@ static const struct dc_debug_options
> debug_defaults_drv = {
> .timing_trace = false,
> .clock_trace = true,
> .disable_pplib_clock_request = true,
> - .pipe_split_policy = MPC_SPLIT_AVOID_MULT_DISP,
> + .pipe_split_policy = MPC_SPLIT_DYNAMIC,
> .force_single_disp_pipe_split = false,
> .disable_dcc = DCC_ENABLE,
> .vsr_support = true,
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_resource.c
> b/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_resource.c
> index 01ba9d656c72..2de687f64cf6 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn303/dcn303_resource.c
> @@ -193,7 +193,7 @@ static const struct dc_debug_options
> debug_defaults_drv = {
> .timing_trace = false,
> .clock_trace = true,
> .disable_pplib_clock_request = true,
> - .pipe_split_policy = MPC_SPLIT_AVOID_MULT_DISP,
> + .pipe_split_policy = MPC_SPLIT_DYNAMIC,
> .force_single_disp_pipe_split = false,
> .disable_dcc = DCC_ENABLE,
> .vsr_support = true,
> diff --git a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
> b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
> index 6d07dcecc953..7c64317a56f7 100644
> --- a/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
> +++ b/drivers/gpu/drm/amd/display/dc/dcn31/dcn31_resource.c
> @@ -1003,7 +1003,7 @@ static const struct dc_debug_options
> debug_defaults_drv = {
> .timing_trace = false,
> .clock_trace = true,
> .disable_pplib_clock_request = false,
> - .pipe_split_policy = MPC_SPLIT_AVOID,
> + .pipe_split_policy = MPC_SPLIT_DYNAMIC,
> .force_single_disp_pipe_split = false,
> .disable_dcc = DCC_ENABLE,
> .vsr_support = true,
> --
> 2.25.1
>
More information about the amd-gfx
mailing list