[RFC PATCH 0/3] Add support modifiers for drivers whose planes only support linear layout
Tomohito Esaki
etom at igel.co.jp
Wed Dec 22 05:27:24 UTC 2021
Some drivers whose planes only support linear layout fb do not support format
modifiers.
These drivers should support modifiers, however the DRM core should handle this
rather than open-coding in every driver.
In this patch series, these drivers expose format modifiers based on the
following suggestion[1].
On Thu, Nov 18, 2021 at 01:02:11PM +0000, Daniel Stone wrote:
> I think the best way forward here is:
> - add a new mode_config.cannot_support_modifiers flag, and enable
> this in radeon (plus any other drivers in the same boat)
> - change drm_universal_plane_init() to advertise the LINEAR modifier
> when NULL is passed as the modifier list (including installing a
> default .format_mod_supported hook)
> - remove the mode_config.allow_fb_modifiers hook and always
> advertise modifier support, unless
> mode_config.cannot_support_modifiers is set
[1] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20190509054518.10781-1-etom@igel.co.jp/#24602575
Tomohito Esaki (3):
drm: add support modifiers for drivers whose planes only support
linear layout
drm: set fb_modifiers_not_supported flag in legacy drivers
drm: replace allow_fb_modifiers with fb_modifiers_not_supported
drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 6 +--
drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 +
drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 +
drivers/gpu/drm/amd/amdgpu/dce_v6_0.c | 1 +
drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 +
drivers/gpu/drm/drm_framebuffer.c | 6 +--
drivers/gpu/drm/drm_ioctl.c | 2 +-
drivers/gpu/drm/drm_plane.c | 41 +++++++++++--------
drivers/gpu/drm/nouveau/nouveau_display.c | 6 ++-
drivers/gpu/drm/radeon/radeon_display.c | 2 +
.../gpu/drm/selftests/test-drm_framebuffer.c | 1 -
include/drm/drm_mode_config.h | 18 +++-----
include/drm/drm_plane.h | 3 ++
13 files changed, 54 insertions(+), 38 deletions(-)
--
2.17.1
More information about the amd-gfx
mailing list