[PATCH] drm/amdgpu: add dummy event6 for vega10

JingWen Chen jingwech at amd.com
Thu Dec 30 10:01:17 UTC 2021


Reviewed-by: Jingwen Chen <Jingwen.Chen2 at amd.com>

On 2021/12/29 下午6:38, James Yao wrote:
> [why]
> Malicious mailbox event1 fails driver loading on vega10.
> An dummy event6 prevent driver from taking response from malicious event1 as its own.
>
> [how]
> On vega10, send a mailbox event6 before sending event1.
>
> Signed-off-by: James Yao <yiqing.yao at amd.com>
> ---
>  drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c |  4 ++++
>  drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c    | 11 +++++++++++
>  drivers/gpu/drm/amd/amdgpu/mxgpu_ai.h    |  2 ++
>  3 files changed, 17 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> index f8e574cc0e22..d9509c3482e2 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c
> @@ -727,6 +727,10 @@ void amdgpu_detect_virtualization(struct amdgpu_device *adev)
>  			vi_set_virt_ops(adev);
>  			break;
>  		case CHIP_VEGA10:
> +			soc15_set_virt_ops(adev);
> +			/* send a dummy GPU_INIT_DATA request to host on vega10 */
> +			amdgpu_virt_request_init_data(adev);
> +			break;
>  		case CHIP_VEGA20:
>  		case CHIP_ARCTURUS:
>  		case CHIP_ALDEBARAN:
> diff --git a/drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c b/drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c
> index 0077e738db31..56da5ab82987 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c
> +++ b/drivers/gpu/drm/amd/amdgpu/mxgpu_ai.c
> @@ -180,6 +180,11 @@ static int xgpu_ai_send_access_requests(struct amdgpu_device *adev,
>  				RREG32_NO_KIQ(SOC15_REG_OFFSET(NBIO, 0,
>  					mmBIF_BX_PF0_MAILBOX_MSGBUF_RCV_DW2));
>  		}
> +	} else if (req == IDH_REQ_GPU_INIT_DATA){
> +		/* Dummy REQ_GPU_INIT_DATA handling */
> +		r = xgpu_ai_poll_msg(adev, IDH_REQ_GPU_INIT_DATA_READY);
> +		/* version set to 0 since dummy */
> +		adev->virt.req_init_data_ver = 0;	
>  	}
>  
>  	return 0;
> @@ -381,10 +386,16 @@ void xgpu_ai_mailbox_put_irq(struct amdgpu_device *adev)
>  	amdgpu_irq_put(adev, &adev->virt.rcv_irq, 0);
>  }
>  
> +static int xgpu_ai_request_init_data(struct amdgpu_device *adev)
> +{
> +	return xgpu_ai_send_access_requests(adev, IDH_REQ_GPU_INIT_DATA);
> +}
> +
>  const struct amdgpu_virt_ops xgpu_ai_virt_ops = {
>  	.req_full_gpu	= xgpu_ai_request_full_gpu_access,
>  	.rel_full_gpu	= xgpu_ai_release_full_gpu_access,
>  	.reset_gpu = xgpu_ai_request_reset,
>  	.wait_reset = NULL,
>  	.trans_msg = xgpu_ai_mailbox_trans_msg,
> +	.req_init_data  = xgpu_ai_request_init_data,
>  };
> diff --git a/drivers/gpu/drm/amd/amdgpu/mxgpu_ai.h b/drivers/gpu/drm/amd/amdgpu/mxgpu_ai.h
> index f9aa4d0bb638..fa7e13e0459e 100644
> --- a/drivers/gpu/drm/amd/amdgpu/mxgpu_ai.h
> +++ b/drivers/gpu/drm/amd/amdgpu/mxgpu_ai.h
> @@ -35,6 +35,7 @@ enum idh_request {
>  	IDH_REQ_GPU_FINI_ACCESS,
>  	IDH_REL_GPU_FINI_ACCESS,
>  	IDH_REQ_GPU_RESET_ACCESS,
> +	IDH_REQ_GPU_INIT_DATA,
>  
>  	IDH_LOG_VF_ERROR       = 200,
>  	IDH_READY_TO_RESET 	= 201,
> @@ -48,6 +49,7 @@ enum idh_event {
>  	IDH_SUCCESS,
>  	IDH_FAIL,
>  	IDH_QUERY_ALIVE,
> +	IDH_REQ_GPU_INIT_DATA_READY,
>  
>  	IDH_TEXT_MESSAGE = 255,
>  };


More information about the amd-gfx mailing list