[PATCH] drm/amd/pm: remove some useless code for vangogh

Wang, Kevin(Yang) Kevin1.Wang at amd.com
Mon Feb 1 08:50:53 UTC 2021

[AMD Official Use Only - Internal Distribution Only]

Reviewed-by: Kevin Wang <kevin1.wang at amd.com>

we'd better to avoid adding ASIC type check in common file...

Best Regards,

From: Du, Xiaojian <Xiaojian.Du at amd.com>
Sent: Monday, February 1, 2021 4:45 PM
To: amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>
Cc: Huang, Ray <Ray.Huang at amd.com>; Quan, Evan <Evan.Quan at amd.com>; Wang, Kevin(Yang) <Kevin1.Wang at amd.com>; Du, Xiaojian <Xiaojian.Du at amd.com>
Subject: [PATCH] drm/amd/pm: remove some useless code for vangogh

This patch is to remove some useless code for vangogh.
In the earlier code, vangogh can't finish all the sequence of
smu late init. But now vangogh has one stable work state,so
remove the useless code.

Signed-off-by: Xiaojian Du <Xiaojian.Du at amd.com>
 drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
index f958b02f9317..30e2a0ac3279 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/amdgpu_smu.c
@@ -612,9 +612,6 @@ static int smu_late_init(void *handle)
                 return ret;

-       if (adev->asic_type == CHIP_VANGOGH)
-               return 0;
         ret = smu_set_default_od_settings(smu);
         if (ret) {
                 dev_err(adev->dev, "Failed to setup default OD settings!\n");

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20210201/a2b9ed30/attachment.htm>

More information about the amd-gfx mailing list