[PATCH] drm/amdkfd: Print unique_id as hex instead of decimal

Felix Kuehling felix.kuehling at amd.com
Wed Feb 3 18:37:40 UTC 2021


Doesn't this break the ABI?

Am 2021-02-03 um 1:22 p.m. schrieb Kent Russell:
> Add a new helper function for printing Topology values to support
> printing 64-bit hex values. Use this for unique_id to ensure that the
> unique_id in KFD's topology matches the one in amdgpu's sysfs pool.
>
> Signed-off-by: Kent Russell <kent.russell at amd.com>
> ---
>  drivers/gpu/drm/amd/amdkfd/kfd_topology.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> index a3fc23873819..4e4f651dcb88 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_topology.c
> @@ -217,6 +217,8 @@ struct kfd_topology_device *kfd_create_topology_device(
>  		sysfs_show_gen_prop(buffer, offs, "%s %u\n", name, value)
>  #define sysfs_show_64bit_prop(buffer, offs, name, value) \
>  		sysfs_show_gen_prop(buffer, offs, "%s %llu\n", name, value)
> +#define sysfs_show_64bit_hex_prop(buffer, offs, name, value) \
> +		sysfs_show_gen_prop(buffer, offs, "%s %llx\n", name, value)
>  #define sysfs_show_32bit_val(buffer, offs, value) \
>  		sysfs_show_gen_prop(buffer, offs, "%u\n", value)
>  #define sysfs_show_str_val(buffer, offs, value) \
> @@ -497,7 +499,7 @@ static ssize_t node_show(struct kobject *kobj, struct attribute *attr,
>  			      dev->node_props.num_sdma_queues_per_engine);
>  	sysfs_show_32bit_prop(buffer, offs, "num_cp_queues",
>  			      dev->node_props.num_cp_queues);
> -	sysfs_show_64bit_prop(buffer, offs, "unique_id",
> +	sysfs_show_64bit_hex_prop(buffer, offs, "unique_id",
>  			      dev->node_props.unique_id);
>  
>  	if (dev->gpu) {


More information about the amd-gfx mailing list