[PATCH 2/2] drm/amdgpu: enable DPM_FLAG_MAY_SKIP_RESUME and DPM_FLAG_SMART_SUSPEND flags

Michal Rostecki mrostecki at suse.de
Thu Feb 4 10:20:47 UTC 2021

On Tue, Feb 02, 2021 at 12:17:48PM -0500, Alex Deucher wrote:
> Once the device has runtime suspended, we don't need to power it
> back up again for system suspend.  Likewise for resume, we don't
> to power up the device again on resume only to power it back off
> again via runtime pm because it's still idle.
> Signed-off-by: Alex Deucher <alexander.deucher at amd.com>

I tested those patches on Dell G5 SE 5505 (RX 5600M / Renoir / 4800H),
which currently suffers from the dc_link_set_backlight_level issue[0].
I have an interesting observation. They don't fix the issue completely,
but after applying them, I'm able to susepnd the laptop once, without
loosing the brightness. Though after suspending the second time, I'm
loosing the brightness and the same usual
amdgpu_dm_backlight_update_status call trace pops out in dmesg.

Everything works properly (with and without patches) on my PC (RX 6900
XT / 5950X).

Since those patches improve the situation a bit on 5600M and work
without issues on 6900 XT, and the backlight race condition needs to be
fully fixes separately, feel free to add:

Tested-by: Michal Rostecki <mrostecki at suse.com>

[0] https://gitlab.freedesktop.org/drm/amd/-/issues/1337

More information about the amd-gfx mailing list