[PATCH] drm/amd/pm: Remove unnecessary conversion to bool

Wang, Kevin(Yang) Kevin1.Wang at amd.com
Sun Feb 7 08:55:14 UTC 2021

[AMD Official Use Only - Internal Distribution Only]

if possible, please correct the same issue in navi10_ppt.c

Reviewed-by: Kevin Wang <kevin1.wang at amd.com>

Best Regards,
From: Jiapeng Chong <jiapeng.chong at linux.alibaba.com>
Sent: Sunday, February 7, 2021 4:49 PM
To: Deucher, Alexander <Alexander.Deucher at amd.com>
Cc: Koenig, Christian <Christian.Koenig at amd.com>; airlied at linux.ie <airlied at linux.ie>; daniel at ffwll.ch <daniel at ffwll.ch>; amd-gfx at lists.freedesktop.org <amd-gfx at lists.freedesktop.org>; dri-devel at lists.freedesktop.org <dri-devel at lists.freedesktop.org>; linux-kernel at vger.kernel.org <linux-kernel at vger.kernel.org>; Jiapeng Chong <jiapeng.chong at linux.alibaba.com>
Subject: [PATCH] drm/amd/pm: Remove unnecessary conversion to bool

Fix the following coccicheck warning:

WARNING: conversion to bool not needed here.

Reported-by: Abaci Robot<abaci at linux.alibaba.com>
Signed-off-by: Jiapeng Chong <jiapeng.chong at linux.alibaba.com>
 drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
index d68d3df..b364862 100644
--- a/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
+++ b/drivers/gpu/drm/amd/pm/swsmu/smu11/sienna_cichlid_ppt.c
@@ -904,7 +904,7 @@ static bool sienna_cichlid_is_support_fine_grained_dpm(struct smu_context *smu,
         dpm_desc = &pptable->DpmDescriptor[clk_index];

         /* 0 - Fine grained DPM, 1 - Discrete DPM */
-       return dpm_desc->SnapToDiscrete == 0 ? true : false;
+       return dpm_desc->SnapToDiscrete != 0;

 static int sienna_cichlid_print_clk_levels(struct smu_context *smu,

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20210207/2ee5b3f1/attachment.htm>

More information about the amd-gfx mailing list