[PATCH v6 2/3] drm/amd/display: Add freesync video modes based on preferred modes

kernel test robot lkp at intel.com
Sat Feb 13 06:10:33 UTC 2021

Hi Aurabindo,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on next-20210211]
[also build test ERROR on v5.11-rc7]
[cannot apply to drm-intel/for-linux-next drm-tip/drm-tip tegra-drm/drm/tegra/for-next linus/master drm-exynos/exynos-drm-next drm/drm-next v5.11-rc7 v5.11-rc6 v5.11-rc5]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in

url:    https://github.com/0day-ci/linux/commits/Aurabindo-Pillai/Freesync-video-mode-optimization/20210213-091059
base:    671176b0016c80b3943cb5387312c886aba3308d
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/1f1eda26f52f0550c11969b7df546591683bda0f
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Aurabindo-Pillai/Freesync-video-mode-optimization/20210213-091059
        git checkout 1f1eda26f52f0550c11969b7df546591683bda0f
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp at intel.com>

Note: the linux-review/Aurabindo-Pillai/Freesync-video-mode-optimization/20210213-091059 HEAD 93e6ddbee724ff17e78a905f919aae4aa280c67b builds fine.
      It only hurts bisectibility.

All errors (new ones prefixed by >>):

   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'amdgpu_dm_connector_add_freesync_modes':
>> drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:7066:8: error: 'amdgpu_exp_freesync_vid_mode' undeclared (first use in this function); did you mean 'amdgpu_freesync_vid_mode'?
    7066 |  if (!(amdgpu_exp_freesync_vid_mode && edid))
         |        ^~~~~~~~~~~~~~~~~~~~~~~~~~~~
         |        amdgpu_freesync_vid_mode
   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:7066:8: note: each undeclared identifier is reported only once for each function it appears in
   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:7062:38: warning: unused variable 'range' [-Wunused-variable]
    7062 |  struct detailed_data_monitor_range *range;
         |                                      ^~~~~
   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:7061:29: warning: unused variable 'data' [-Wunused-variable]
    7061 |  struct detailed_non_pixel *data;
         |                             ^~~~
   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:7060:26: warning: unused variable 'timing' [-Wunused-variable]
    7060 |  struct detailed_timing *timing;
         |                          ^~~~~~
   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:7059:10: warning: unused variable 'i' [-Wunused-variable]
    7059 |  uint8_t i;
         |          ^
   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c: In function 'amdgpu_dm_commit_cursors':
   drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c:7805:44: warning: variable 'new_plane_state' set but not used [-Wunused-but-set-variable]
    7805 |  struct drm_plane_state *old_plane_state, *new_plane_state;
         |                                            ^~~~~~~~~~~~~~~

Kconfig warnings: (for reference only)
   WARNING: unmet direct dependencies detected for FRAME_POINTER
   Selected by

vim +7066 drivers/gpu/drm/amd/amdgpu/../display/amdgpu_dm/amdgpu_dm.c

  7056	static void amdgpu_dm_connector_add_freesync_modes(struct drm_connector *connector,
  7057							   struct edid *edid)
  7058	{
  7059		uint8_t i;
  7060		struct detailed_timing *timing;
  7061		struct detailed_non_pixel *data;
  7062		struct detailed_data_monitor_range *range;
  7063		struct amdgpu_dm_connector *amdgpu_dm_connector =
  7064			to_amdgpu_dm_connector(connector);
> 7066		if (!(amdgpu_exp_freesync_vid_mode && edid))
  7067			return;
  7069		if (amdgpu_dm_connector->max_vfreq - amdgpu_dm_connector->min_vfreq > 10)
  7070			amdgpu_dm_connector->num_modes +=
  7071				add_fs_modes(amdgpu_dm_connector);
  7072	}

0-DAY CI Kernel Test Service, Intel Corporation
-------------- next part --------------
A non-text attachment was scrubbed...
Name: .config.gz
Type: application/gzip
Size: 63769 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/amd-gfx/attachments/20210213/db09a23e/attachment-0001.gz>

More information about the amd-gfx mailing list