[PATCH] drm/amdgpu: check the result of copy_from_user in secure display debugfs (v2)

Alex Deucher alexdeucher at gmail.com
Mon Jan 4 17:53:37 UTC 2021


Make sure the copy succeeded.  Also fixes a warning.

v2: fix the error check

Signed-off-by: Alex Deucher <alexander.deucher at amd.com>
---
 drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c
index 455978781380..b033344c5ce2 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_securedisplay.c
@@ -101,7 +101,9 @@ static ssize_t amdgpu_securedisplay_debugfs_write(struct file *f, const char __u
 		return -EINVAL;
 
 	memset(str,  0, sizeof(str));
-	copy_from_user(str, buf, size);
+	ret = copy_from_user(str, buf, size);
+	if (ret)
+		return -EFAULT;
 
 	ret = pm_runtime_get_sync(dev->dev);
 	if (ret < 0) {
-- 
2.29.2



More information about the amd-gfx mailing list